* Timesheet - Fix 0 quantity was not allowed

This commit is contained in:
nathangray 2017-08-25 10:11:31 -06:00
parent 61dc75621d
commit 6539b66cdc

View File

@ -187,13 +187,13 @@ class timesheet_ui extends timesheet_bo
case 'save': case 'save':
case 'save_new': case 'save_new':
case 'apply': case 'apply':
if ((!$this->data['ts_quantity'] || $this->ts_viewtype == 'short') && $this->data['ts_duration']) // set the quantity (in h) from the duration (in min) if (($this->data['ts_quantity'] === '' || $this->ts_viewtype == 'short') && $this->data['ts_duration']) // set the quantity (in h) from the duration (in min)
{ {
// We need to keep the actual value of ts_quantity when we are storing it, as it is used in price calculation // We need to keep the actual value of ts_quantity when we are storing it, as it is used in price calculation
// and rounding it causes miscalculation on prices // and rounding it causes miscalculation on prices
$this->data['ts_quantity'] = $this->data['ts_duration'] / 60.0; $this->data['ts_quantity'] = $this->data['ts_duration'] / 60.0;
} }
if (!$this->data['ts_quantity']) if ($this->data['ts_quantity'] === '')
{ {
$etpl->set_validation_error('ts_quantity',lang('Field must not be empty !!!')); $etpl->set_validation_error('ts_quantity',lang('Field must not be empty !!!'));
} }