From 69ce6640000df61576227ee24e67bde588eb7d53 Mon Sep 17 00:00:00 2001 From: Hadi Nategh Date: Wed, 5 Oct 2016 17:13:07 +0200 Subject: [PATCH] Fix some of content in mails with specific html formats get removed by HtmLawed's balance --- api/src/Mail.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api/src/Mail.php b/api/src/Mail.php index 9b78a7f4e9..82710aa88b 100644 --- a/api/src/Mail.php +++ b/api/src/Mail.php @@ -131,7 +131,8 @@ class Mail static $htmLawed_config = array('comment'=>1, //remove comments 'make_tag_strict' => 3, // 3 is a new own config value, to indicate that transformation is to be performed, but don't transform font as size transformation of numeric sizes to keywords alters the intended result too much 'keep_bad'=>2, //remove tags but keep element content (4 and 6 keep element content only if text (pcdata) is valid in parent element as per specs, this may lead to textloss if balance is switched on) - 'balance'=>1,//turn off tag-balancing (config['balance']=>0). That will not introduce any security risk; only standards-compliant tag nesting check/filtering will be turned off (basic tag-balance will remain; i.e., there won't be any unclosed tag, etc., after filtering) + // we switch the balance off because of some broken html mails contents get removed like (td in table), and let browser deal with it + 'balance'=>0,//turn off tag-balancing (config['balance']=>0). That will not introduce any security risk; only standards-compliant tag nesting check/filtering will be turned off (basic tag-balance will remain; i.e., there won't be any unclosed tag, etc., after filtering) 'direct_list_nest' => 1, 'allow_for_inline' => array('table','div','li','p'),//block elements allowed for nesting when only inline is allowed; Example span does not allow block elements as table; table is the only element tested so far // tidy eats away even some wanted whitespace, so we switch it off;