extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-07 08:34:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

improve speed for read access / grants to a lot of accounts

Browse Source 
first check then spend time generating the list ;)
This commit is contained in:
ralf 2024-10-29 12:32:08 +01:00
parent 875c78abbf
commit 6b24c1f7c2
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
timesheet/inc/class.timesheet_ui.inc.php
View File

@ -1031,26 +1031,30 @@ class timesheet_ui extends timesheet_bo
{ {
$content['nm']['no_kanban'] = true; $content['nm']['no_kanban'] = true;
} }
$read_grants = $this->grant_list(Acl::READ);
$content['nm']['no_owner_col'] = count($read_grants) == 1;
if($GLOBALS['egw_info']['user']['preferences']['timesheet']['nextmatch-timesheet.index.rows']) if($GLOBALS['egw_info']['user']['preferences']['timesheet']['nextmatch-timesheet.index.rows'])
{ {
$content['nm']['selectcols'] = $GLOBALS['egw_info']['user']['preferences']['timesheet']['nextmatch-timesheet.index.rows']; $content['nm']['selectcols'] = $GLOBALS['egw_info']['user']['preferences']['timesheet']['nextmatch-timesheet.index.rows'];
} }
$sel_options = array( $sel_options = array(
'ts_owner' => $read_grants,
'pm_id' => array(lang('No project')), 'pm_id' => array(lang('No project')),
'cat_id' => array(array('value' => '', 'label' => lang('all categories')), 'cat_id' => array(array('value' => '', 'label' => lang('all categories')),
array('value' => 0, 'label' => lang('None'))), array('value' => 0, 'label' => lang('None'))),
'ts_status' => $this->status_labels + array(lang('No status')), 'ts_status' => $this->status_labels + array(lang('No status')),
); );
// Special handling for if you have a LOT of accounts - use a regular account widget // Special handling for having access to a LOT of accounts - use a regular account widget
if(count($sel_options['ts_owner']) > Api\Accounts::HUGE_LIMIT) if(count(array_filter($this->grants, static function($grant)
{
return (bool)($grant & Acl::READ);
})) > Api\Accounts::HUGE_LIMIT)
{ {
unset($sel_options['ts_owner']);
$etpl->setElementAttribute('ts_owner', 'type', 'et2-nextmatch-header-account'); $etpl->setElementAttribute('ts_owner', 'type', 'et2-nextmatch-header-account');
$etpl->setElementAttribute('ts_owner', 'accountType', 'accounts'); $etpl->setElementAttribute('ts_owner', 'accountType', 'accounts');
} }
else
{
$sel_options['ts_owner'] = $this->grant_list(Acl::READ);
$content['nm']['no_owner_col'] = count($sel_options['ts_owner']) === 1;
}
if($this->config_data['history']) if($this->config_data['history'])
{ {
$sel_options['ts_status'][self::DELETED_STATUS] = 'Deleted'; $sel_options['ts_status'][self::DELETED_STATUS] = 'Deleted';
@ -1060,7 +1064,7 @@ class timesheet_ui extends timesheet_bo
if ($this->pm_integration != 'full') if ($this->pm_integration != 'full')
{ {
$projects =& $this->query_list('ts_project'); $projects = $this->query_list('ts_project');
if (!is_array($projects)) $projects = array(); if (!is_array($projects)) $projects = array();
$sel_options['ts_project'] = $projects + array(lang('No project')); $sel_options['ts_project'] = $projects + array(lang('No project'));
} }