From 7522e7615fc44a7aac18d402ad9660cc9768306f Mon Sep 17 00:00:00 2001
From: ralf <rb@egroupware.org>
Date: Tue, 7 Feb 2023 08:19:24 +0100
Subject: [PATCH] fix Argument 2 passed to
 EGroupware\Api\Mail\Smtp::mailbox_address() must be of the type string, null
 given called in /usr/share/egroupware/api/src/Mail/Smtp.php on line 238
 caused by no mail domain specified in config or mail account

---
 api/src/Mail/Smtp.php      | 11 ++++++-----
 api/src/Mail/Smtp/Ldap.php |  6 +++---
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/api/src/Mail/Smtp.php b/api/src/Mail/Smtp.php
index 0a207c6041..75cb9813fb 100644
--- a/api/src/Mail/Smtp.php
+++ b/api/src/Mail/Smtp.php
@@ -244,13 +244,12 @@ class Smtp
 	 * If $account is an array (with values for keys account_(id|lid|email), it does NOT call accounts class
 	 *
 	 * @param int|array $account account_id or whole account array with values for keys
-	 * @param string $domain domain
+	 * @param string $domain|null domain
 	 * @param string $mail_login_type=null standard(uid), vmailmgr(uid@domain), email or uidNumber
-	 * @return string
+	 * @return string|null null if no domain given but required by $mail_login_type
 	 */
-	static public function mailbox_address($account, string $domain, string $mail_login_type=null)
+	static public function mailbox_address($account, string $domain=null, string $mail_login_type=null)
 	{
-
 		switch($mail_login_type)
 		{
 			case 'email':
@@ -258,6 +257,7 @@ class Smtp
 				break;
 
 			case 'uidNumber':
+				if (empty($domain)) return null;
 				if (is_array($account)) $account = $account['account_id'];
 				$mbox = 'u'.$account.'@'.$domain;
 				break;
@@ -268,6 +268,7 @@ class Smtp
 
 			case 'vmailmgr':
 			default:
+				if (empty($domain)) return null;
 				$mbox = is_array($account) ? $account['account_lid'] : $GLOBALS['egw']->accounts->id2name($account);
 				$mbox .= '@'.$domain;
 				break;
@@ -276,4 +277,4 @@ class Smtp
 
 		return $mbox;
 	}
-}
+}
\ No newline at end of file
diff --git a/api/src/Mail/Smtp/Ldap.php b/api/src/Mail/Smtp/Ldap.php
index 99d21581c5..6588da1d84 100644
--- a/api/src/Mail/Smtp/Ldap.php
+++ b/api/src/Mail/Smtp/Ldap.php
@@ -251,9 +251,9 @@ class Ldap extends Mail\Smtp
 				$mailLocalAddress : static::MAIL_ENABLED;
 		}
 		// does schema support an explicit mailbox name --> set it
-		if (static::MAILBOX_ATTR)
+		if (static::MAILBOX_ATTR && !empty($mailbox = self::mailbox_addr($_hookValues)))
 		{
-			$newData[static::MAILBOX_ATTR] = self::mailbox_addr($_hookValues);
+			$newData[static::MAILBOX_ATTR] = $mailbox;
 		}
 
 		// allow extending classes to add extra data
@@ -862,4 +862,4 @@ class Ldap extends Mail\Smtp
 	{
 		return Api\Ldap::factory();
 	}
-}
+}
\ No newline at end of file