From 78752738d24ac543de8ac0b461f7108ae451f3f9 Mon Sep 17 00:00:00 2001 From: nathangray Date: Mon, 5 Nov 2018 15:54:26 -0700 Subject: [PATCH] Fix Select All sometimes misses rows if there's between 50 and 1000 and you scroll down --- api/js/etemplate/et2_dataview_controller_selection.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/api/js/etemplate/et2_dataview_controller_selection.js b/api/js/etemplate/et2_dataview_controller_selection.js index 0e10ac0cb4..7346dc1f36 100644 --- a/api/js/etemplate/et2_dataview_controller_selection.js +++ b/api/js/etemplate/et2_dataview_controller_selection.js @@ -355,6 +355,12 @@ var et2_dataview_selectionManager = (function(){ "use strict"; return Class.exte // Create an action object for the tr and connect it to a dummy AOI if(this._actionObjectManager) { + if(this._actionObjectManager.getObjectById(_uid)) + { + var state = _entry.state; + this._actionObjectManager.getObjectById(_uid).remove(); + _entry.state = state; + } _entry.ao = this._actionObjectManager.addObject(_uid, dummyAOI); } @@ -656,7 +662,9 @@ var et2_dataview_selectionManager = (function(){ "use strict"; return Class.exte var data = egw.dataGetUIDdata(_order[j]); if(!data || data && data.data && !data.data.no_actions) { - this.setSelected(_order[j], true); + var entry = this._getRegisteredRowsEntry(_order[j]); + this._updateEntryState(entry, + egwSetBit(entry.state, EGW_AO_STATE_SELECTED, true)); } } progressbar.set_value(100*(++range_index/range_count));