From 788bc9ff3ebadd8cf56b02e3a0a3677b660bc18f Mon Sep 17 00:00:00 2001
From: Hadi Nategh <hn@stylite.de>
Date: Fri, 31 Oct 2014 10:50:30 +0000
Subject: [PATCH] Fix re-positioning mail preview content according to its
 visible sibilings

---
 mail/js/app.js                  | 42 +++++++++++++++++++--------------
 mail/templates/default/app.css  |  6 -----
 mail/templates/pixelegg/app.css |  6 -----
 3 files changed, 24 insertions(+), 30 deletions(-)

diff --git a/mail/js/app.js b/mail/js/app.js
index 4def2c5a05..c88800743a 100644
--- a/mail/js/app.js
+++ b/mail/js/app.js
@@ -758,31 +758,37 @@ app.classes.mail = AppJS.extend(
 		//dataElem.data is populated, when available with fromaddress(string),toaddress(string),additionaltoaddress(array),ccaddress (array)
 		var dataElem = {data:{subject:"",fromaddress:"",toaddress:"",ccaddress:"",date:"",attachmentsBlock:""}};
 		var attachmentArea = this.et2.getWidgetById('previewAttachmentArea');
-		var previewContainer = this.et2.getWidgetById('mailPreviewContainer');
 		if(typeof selected != 'undefined' && selected.length == 1)
 		{
 			var _id = this.mail_fetchCurrentlyFocussed(selected);
 			dataElem = jQuery.extend(dataElem, egw.dataGetUIDdata(_id));
 		}
-
+		
+		var $preview_iframe = jQuery('#mail-index_mailPreviewContainer');
+		
+		// Re calculate the position of preview iframe according to its visible sibilings
+		var set_prev_iframe_top = function ()
+		{
+			// Need to make sure that the iframe is fullyLoad before calculation
+			window.setTimeout(function(){
+				var lastEl = $preview_iframe.prev().prev();
+				// Top offset of preview iframe calculated from top level
+				var iframeTop = $preview_iframe.offset().top;
+				while (lastEl.css('display') === "none")
+				{
+					lastEl = lastEl.prev();
+				}
+				var offset = iframeTop - (lastEl.offset().top + lastEl.height()) || 130; // fallback to 130 px if can not calculate new top
+				
+				// preview iframe parent has position absolute, therefore need to calculate the top via position
+				$preview_iframe.css ('top', $preview_iframe.position().top - offset + 10);
+			}, 50);
+		}
+		
 		if (attachmentArea && typeof _id != 'undefined' && _id !='' && typeof dataElem !== 'undefined')
 		{
-			this.et2.getWidgetById('previewAttachmentArea').set_class('previewAttachmentArea');
-			if (!dataElem.data.attachmentsBlock)
-			{
-				if (!dataElem.data.ccaddress)
-				{
-					previewContainer.set_class('previewNoAttachment');
-				}
-				else
-				{
-					previewContainer.set_class('previewNoAttachmentButCC');
-				}
-			}
-			else
-			{
-				jQuery(previewContainer.node).removeClass('previewNoAttachment previewNoAttachmentButCC');
-			}
+			// If there is content to show recalculate the size
+			set_prev_iframe_top();
 		}
 		else
 		{
diff --git a/mail/templates/default/app.css b/mail/templates/default/app.css
index ff31479230..16a9569191 100644
--- a/mail/templates/default/app.css
+++ b/mail/templates/default/app.css
@@ -502,12 +502,6 @@ div.mail-compose_fileselector {
 	left: 3px;
 	right: 0;
 }
-#mail-index_mailPreviewContainer.previewNoAttachment {
-	top: 51px;
-}
-#mail-index_mailPreviewContainer.previewNoAttachmentButCC{
-	top: 67px;
-}
 #mail-index_previewAttachmentArea {
 	background-color:#f0f0f0;
 	max-height: 1.6em;
diff --git a/mail/templates/pixelegg/app.css b/mail/templates/pixelegg/app.css
index cec3ee6956..fedea2b17d 100755
--- a/mail/templates/pixelegg/app.css
+++ b/mail/templates/pixelegg/app.css
@@ -502,12 +502,6 @@ div.mail-compose_fileselector {
   left: 3px;
   right: 0;
 }
-#mail-index_mailPreviewContainer.previewNoAttachment {
-  top: 51px;
-}
-#mail-index_mailPreviewContainer.previewNoAttachmentButCC {
-  top: 67px;
-}
 #mail-index_previewAttachmentArea {
   background-color: #f0f0f0;
   max-height: 1.6em;