extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-27 09:09:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Restrict anonymous user, fix noEdit class not set on all rows

Browse Source
This commit is contained in:
nathangray 2017-10-30 11:25:12 -06:00
parent 6272adfa16
commit 7e7733e4e9
1 changed files with 42 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
filemanager/inc/class.filemanager_ui.inc.php
View File

@ -308,6 +308,12 @@ class filemanager_ui
$actions['paste']['children']["{$action_id}_paste"] = $action; $actions['paste']['children']["{$action_id}_paste"] = $action;
} }
} }
// Anonymous users have limited actions
if(self::is_anonymous($GLOBALS['egw_info']['user']['account_id']))
{
self::restrict_anonymous_actions($actions);
}
return $actions; return $actions;
} }
@ -957,13 +963,14 @@ class filemanager_ui
{ {
$dir_is_writable[$path] = Vfs::is_writable($path); $dir_is_writable[$path] = Vfs::is_writable($path);
} }
$row['class'] .= 'isDir ';
$row['is_dir'] = 1;
}
if(!$dir_is_writable[$path]) if(!$dir_is_writable[$path])
{ {
$row['class'] .= 'noEdit '; $row['class'] .= 'noEdit ';
} }
$row['class'] .= 'isDir ';
$row['is_dir'] = 1;
}
$row['download_url'] = Vfs::download_url($path); $row['download_url'] = Vfs::download_url($path);
$row['gid'] = -abs($row['gid']); // gid are positive, but we use negagive account_id for groups internal $row['gid'] = -abs($row['gid']); // gid are positive, but we use negagive account_id for groups internal
@ -1412,9 +1419,40 @@ class filemanager_ui
Framework::window_focus(); Framework::window_focus();
$GLOBALS['egw_info']['flags']['app_header'] = lang('Preferences').' '.Vfs::decodePath($path); $GLOBALS['egw_info']['flags']['app_header'] = lang('Preferences').' '.Vfs::decodePath($path);
// Anonymous users cannot do anything
if(self::is_anonymous($GLOBALS['egw_info']['user']['account_id']))
{
$readonlys['__ALL__'] = true;
$readonlys['gid'] = true;
}
$tpl->exec('filemanager.filemanager_ui.file',$content,$sel_options,$readonlys,$preserve,2); $tpl->exec('filemanager.filemanager_ui.file',$content,$sel_options,$readonlys,$preserve,2);
} }
/**
* Check if the user is anonymous user
* @param type $user_id
*/
protected static function is_anonymous($user_id)
{
return in_array($user_id, $GLOBALS['egw']->accounts->members('NoGroup', true));
}
/**
* Remove some more dangerous actions
* @param Array $actions
*/
protected static function restrict_anonymous_actions(&$actions)
{
$remove = array(
'delete'
);
foreach($remove as $key)
{
unset($actions[$key]);
}
}
/** /**
* Run given action on given path(es) and return array/object with values for keys 'msg', 'errs', 'dirs', 'files' * Run given action on given path(es) and return array/object with values for keys 'msg', 'errs', 'dirs', 'files'
* *