extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2025-02-05 21:09:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make diff check static

Browse Source
This commit is contained in:
nathangray 2019-02-27 10:48:10 -07:00
parent 0ddcd3e9f8
commit 7e7e198299
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/src/Storage/History.php
View File

@ -261,8 +261,8 @@ class History
} }
} }
if ($row['history_old_value'] !== Tracking::DIFF_MARKER && ( if ($row['history_old_value'] !== Tracking::DIFF_MARKER && (
$this->needs_diff($row['history_status'], $row['history_old_value']) || static::needs_diff($row['history_status'], $row['history_old_value']) ||
$this->needs_diff($row['history_status'], $row['history_old_value']) static::needs_diff($row['history_status'], $row['history_old_value'])
)) ))
{ {
// Larger text stored with full old / new value - calculate diff and just send that // Larger text stored with full old / new value - calculate diff and just send that
@ -309,7 +309,7 @@ class History
return $total; return $total;
} }
protected function needs_diff($name, $value) protected static function needs_diff($name, $value)
{ {
return $name == 'note' || $name == 'description' || return $name == 'note' || $name == 'description' ||
($value && (strlen($value) > 50 || strstr($value, "\n") !== FALSE)); ($value && (strlen($value) > 50 || strstr($value, "\n") !== FALSE));