From 81d63b6c12a2da269ef872297ec634c27f4c2a4f Mon Sep 17 00:00:00 2001 From: nathan Date: Wed, 13 Dec 2023 11:09:22 -0700 Subject: [PATCH] Fix vfsWidget sometimes gives "TypeError: Cannot read properties of null (reading 'get_value')" It was trying to access template widgets before they had loaded. Fixed to wait until load is done. --- api/js/etemplate/et2_widget_vfs.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/api/js/etemplate/et2_widget_vfs.ts b/api/js/etemplate/et2_widget_vfs.ts index a091cba39c..f490614992 100644 --- a/api/js/etemplate/et2_widget_vfs.ts +++ b/api/js/etemplate/et2_widget_vfs.ts @@ -1274,13 +1274,14 @@ export class et2_vfsSelect extends et2_inputWidget }); document.body.appendChild(this.dialog); - this.dialog.addEventListener('open', function(e) + // Wait for dialog to finish loading + this.dialog.updateComplete.then(() => { app.vfsSelectUI.et2 = self.dialog.template.widgetContainer; app.vfsSelectUI.vfsSelectWidget = self; app.vfsSelectUI.et2_ready(app.vfsSelectUI.et2, 'api.vfsSelectUI'); app.vfsSelectUI.et2.getInstanceManager().app_obj['vfsSelectUI'] = app.vfsSelectUI; - }); + }) this.dialog.addEventListener("close", () => { self.dialog = undefined;