extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-07 08:34:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix removing a nm row did not re-index

Browse Source 
This caused duplications or holes depending on what you did before or after
This commit is contained in:
nathangray 2020-08-07 14:12:30 -06:00 committed by Ralf Becker
parent 7752fe03de
commit 8f769a9550
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/js/etemplate/et2_extension_nextmatch.js
View File

@ -571,7 +571,7 @@ var et2_nextmatch = /** @class */ (function (_super) {
var entry = this.controller._selectionMgr._getRegisteredRowsEntry(uid); var entry = this.controller._selectionMgr._getRegisteredRowsEntry(uid);
// Need to delete first as there's a good chance indexes will change in an unknown way // Need to delete first as there's a good chance indexes will change in an unknown way
// and we can't always find it by UID after due to duplication // and we can't always find it by UID after due to duplication
this.controller._grid.deleteRow(entry.idx); this.controller.deleteRow(uid);
// Pretend it's a new row, let app tell us where it goes and we'll mark it as new // Pretend it's a new row, let app tell us where it goes and we'll mark it as new
if (!this.refresh_add(uid, et2_nextmatch.UPDATE)) { if (!this.refresh_add(uid, et2_nextmatch.UPDATE)) {
// App did not want the row, or doesn't know where it goes but we've already removed it... // App did not want the row, or doesn't know where it goes but we've already removed it...

2
api/js/etemplate/et2_extension_nextmatch.ts
View File

@ -863,7 +863,7 @@ export class et2_nextmatch extends et2_DOMWidget implements et2_IResizeable, et2
// Need to delete first as there's a good chance indexes will change in an unknown way // Need to delete first as there's a good chance indexes will change in an unknown way
// and we can't always find it by UID after due to duplication // and we can't always find it by UID after due to duplication
this.controller._grid.deleteRow(entry.idx); this.controller.deleteRow(uid);
// Pretend it's a new row, let app tell us where it goes and we'll mark it as new // Pretend it's a new row, let app tell us where it goes and we'll mark it as new
if(!this.refresh_add(uid, et2_nextmatch.UPDATE)) if(!this.refresh_add(uid, et2_nextmatch.UPDATE))