From a435f90c0893f913b0b6c87b397ca63096b603d9 Mon Sep 17 00:00:00 2001 From: Ralf Becker Date: Tue, 26 Sep 2006 04:50:37 +0000 Subject: [PATCH] fixed bug "infolog filter 'responsible open' does not show all items the user is responsible for", it was caused by the update of existing entries writes '' into info_responsible instead of '0' --- infolog/inc/class.soinfolog.inc.php | 4 ++-- infolog/setup/setup.inc.php | 2 +- infolog/setup/tables_update.inc.php | 11 ++++++++++- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/infolog/inc/class.soinfolog.inc.php b/infolog/inc/class.soinfolog.inc.php index 5e317a2052..8e1388e458 100644 --- a/infolog/inc/class.soinfolog.inc.php +++ b/infolog/inc/class.soinfolog.inc.php @@ -385,9 +385,9 @@ //echo "soinfolog::write(,$check_modified) values="; _debug_array($values); $info_id = (int) $values['info_id']; - if (isset($values['info_responsible'])) + if (array_key_exists('info_responsible',$values)) // isset($values['info_responsible']) returns false for NULL! { - $values['info_responsible'] = count($values['info_responsible']) ? implode(',',$values['info_responsible']) : '0'; + $values['info_responsible'] = $values['info_responsible'] ? implode(',',$values['info_responsible']) : '0'; } $table_def = $this->db->get_table_definitions('infolog',$this->info_table); $to_write = array(); diff --git a/infolog/setup/setup.inc.php b/infolog/setup/setup.inc.php index 178834c23d..c2d115f641 100755 --- a/infolog/setup/setup.inc.php +++ b/infolog/setup/setup.inc.php @@ -12,7 +12,7 @@ /* $Id$ */ $setup_info['infolog']['name'] = 'infolog'; - $setup_info['infolog']['version'] = '1.2.003'; + $setup_info['infolog']['version'] = '1.2.004'; $setup_info['infolog']['app_order'] = 5; $setup_info['infolog']['tables'] = array('egw_infolog','egw_infolog_extra'); $setup_info['infolog']['enable'] = 1; diff --git a/infolog/setup/tables_update.inc.php b/infolog/setup/tables_update.inc.php index 5f473ca763..bc346861d3 100644 --- a/infolog/setup/tables_update.inc.php +++ b/infolog/setup/tables_update.inc.php @@ -546,4 +546,13 @@ } return $GLOBALS['setup_info']['infolog']['currentver'] = '1.2.003'; } -?> + + + $test[] = '1.2.003'; + function infolog_upgrade1_2_003() + { + // fix wrong info_responsible='' --> '0' + $GLOBALS['egw_setup']->oProc->query("UPDATE egw_infolog SET info_responsible='0' WHERE info_responsible=''",__LINE__,__FILE__); + + return $GLOBALS['setup_info']['infolog']['currentver'] = '1.2.004'; + }