From b4dfee24ffd4cfc5b0459015d0c78ac76e4326c9 Mon Sep 17 00:00:00 2001
From: nathangray <nathangray.bsc+github@gmail.com>
Date: Mon, 30 May 2016 10:02:57 -0600
Subject: [PATCH] Fix sudo() always returned true, even if you got the password
 wrong

---
 filemanager/inc/class.filemanager_ui.inc.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/filemanager/inc/class.filemanager_ui.inc.php b/filemanager/inc/class.filemanager_ui.inc.php
index 1da9668e54..941f66a150 100644
--- a/filemanager/inc/class.filemanager_ui.inc.php
+++ b/filemanager/inc/class.filemanager_ui.inc.php
@@ -377,9 +377,10 @@ class filemanager_ui
 				in_array($user,preg_split('/, */',$GLOBALS['egw_info']['server']['vfs_root_user'])) &&
 				$GLOBALS['egw']->auth->authenticate($user, $password, 'text');
 		}
-		//echo "<p>".__METHOD__."('$user','$password',$is_setup) user_pw_hash(...)='".Api\Session::user_pw_hash($user,$password)."', config_hash='{$GLOBALS['egw_info']['server']['config_hash']}' --> returning ".array2string($is_root)."</p>\n";
+		//error_log(__METHOD__."('$user','$password',$is_setup) user_pw_hash(...)='".Api\Session::user_pw_hash($user,$password)."', config_hash='{$GLOBALS['egw_info']['server']['config_hash']}' --> returning ".array2string($is_root));
 		Api\Cache::setSession('filemanager', 'is_setup',$is_setup);
-		return Api\Cache::setSession('filemanager', 'is_root',Vfs::$is_root = $is_root);
+		Api\Cache::setSession('filemanager', 'is_root',Vfs::$is_root = $is_root);
+		return Vfs::$is_root;
 	}
 
 	/**