extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2024-10-09 03:32:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

fixed async job was not removed, if facations was deactivated and only try to reschedule with increasing intervals for 2 days

Browse Source
This commit is contained in:
Ralf Becker 2014-07-22 12:52:28 +00:00
parent a66066fbc5
commit d9ae69e044
1 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
mail/inc/class.mail_sieve.inc.php
View File

@ -48,14 +48,14 @@ class mail_sieve
* @var boolean * @var boolean
*/ */
var $is_admin_vac = false; var $is_admin_vac = false;
/** /**
* siteConfigs * siteConfigs
* *
* @var array * @var array
*/ */
var $mailConfig = array(); var $mailConfig = array();
/** /**
* Constructor * Constructor
*/ */
@ -64,13 +64,13 @@ class mail_sieve
$this->displayCharset = translation::charset(); $this->displayCharset = translation::charset();
$this->mail_admin = isset($GLOBALS['egw_info']['user']['apps']['emailadmin']); $this->mail_admin = isset($GLOBALS['egw_info']['user']['apps']['emailadmin']);
$this->mailConfig = config::read('mail'); $this->mailConfig = config::read('mail');
$acc_id = isset($_GET['acc_id']) ? (int)$_GET['acc_id'] : egw_cache::getSession(__CLASS__, 'acc_id'); $acc_id = isset($_GET['acc_id']) ? (int)$_GET['acc_id'] : egw_cache::getSession(__CLASS__, 'acc_id');
if ($acc_id > 0) if ($acc_id > 0)
{ {
$this->account = emailadmin_account::read($acc_id); $this->account = emailadmin_account::read($acc_id);
} }
$this->restoreSessionData(); $this->restoreSessionData();
} }
@ -507,6 +507,7 @@ class mail_sieve
elseif ($content['acc_id']) elseif ($content['acc_id'])
{ {
$this->account = emailadmin_account::read($content['acc_id']); $this->account = emailadmin_account::read($content['acc_id']);
$preserv['acc_id'] = $content['acc_id'];
} }
$icServer = $this->account->imapServer($this->is_admin_vac ? $account_id : false); $icServer = $this->account->imapServer($this->is_admin_vac ? $account_id : false);
@ -614,7 +615,8 @@ class mail_sieve
// schedule job to switch message on/off, if request and not already in past // schedule job to switch message on/off, if request and not already in past
else else
{ {
if ($newVacation['status'] == 'by_date' && $newVacation['end_date']+24*3600 > time()) if ($newVacation['status'] == 'by_date' && $newVacation['end_date']+24*3600 > time() ||
$vacRules && $vacRules['vacation']['status'] == 'by_date')
{ {
self::setAsyncJob($newVacation); self::setAsyncJob($newVacation);
} }
@ -694,17 +696,22 @@ class mail_sieve
$async->delete($async_id); $async->delete($async_id);
$end_date = $_vacation['end_date'] + 24*3600; // end-date is inclusive, so we have to add 24h $end_date = $_vacation['end_date'] + 24*3600; // end-date is inclusive, so we have to add 24h
if ($_vacation['status'] == 'by_date' && time() < $end_date && $_reschedule===false) if ($_vacation['status'] == 'by_date' && time() < $end_date && !$_reschedule)
{ {
$time = time() < $_vacation['start_date'] ? $_vacation['start_date'] : $end_date; $time = time() < $_vacation['start_date'] ? $_vacation['start_date'] : $end_date;
$async->set_timer($time,$async_id, 'mail_sieve::async_vacation', $_vacation, $_vacation['account_id']); $async->set_timer($time,$async_id, 'mail_sieve::async_vacation', $_vacation, $_vacation['account_id']);
} }
if ($_reschedule) if ($_reschedule)
{ {
$time = time() + 60*3; $_vacation['rescheduled'] = $_vacation['rescheduled'] ? 2*$_vacation['rescheduled'] : 5;
unset($_vacation['next']); // only try to reschedule for 2 days max
unset($_vacation['times']); if ($_vacation['rescheduled'] <= 2 * 24 * 60)
$async->set_timer($time, $async_id, 'mail_sieve::async_vacation', $_vacation, $_vacation['account_id']); {
$time = time() + 60*($_vacation['rescheduled']);
unset($_vacation['next']);
unset($_vacation['times']);
$async->set_timer($time, $async_id, 'mail_sieve::async_vacation', $_vacation, $_vacation['account_id']);
}
} }
} }
@ -728,6 +735,12 @@ class mail_sieve
$ret = $icServer->setVacationUser($_vacation['account_id'], null, $_vacation); $ret = $icServer->setVacationUser($_vacation['account_id'], null, $_vacation);
self::setAsyncJob($_vacation); self::setAsyncJob($_vacation);
} }
// if mail account no longer exists --> remove async job
catch (egw_exception_not_found $e)
{
$_vacation['status'] = 'off';
self::setAsyncJob($_vacation);
}
catch (Exception $e) { catch (Exception $e) {
error_log(__METHOD__.'('.array2string($_vacation).' failed '.$e->getMessage()); error_log(__METHOD__.'('.array2string($_vacation).' failed '.$e->getMessage());
self::setAsyncJob($_vacation, true); // reschedule self::setAsyncJob($_vacation, true); // reschedule