extern/egroupware
1
0
Fork 1
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-03 20:49:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix customfield type "button" without any value stalls whole addressbook

Browse Source
This commit is contained in:
Ralf Becker 2014-11-14 12:39:01 +00:00
parent acbffe344e
commit e59d6fc617
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
etemplate/js/et2_extension_customfields.js
View File

@ -503,21 +503,26 @@ var et2_customfields_list = et2_valueWidget.extend([et2_IDetachedDOM, et2_IInput
attrs.label = field.label; attrs.label = field.label;
if (this._type == 'customfields-list')
{
// No buttons in a list, it causes problems with detached nodes
return false;
}
// Simple case, one widget for a custom field // Simple case, one widget for a custom field
if(Object.keys(field.values).length == 1) if(!field.values || typeof field.values != 'object' || Object.keys(field.values).length == 1)
{ {
for(var key in field.values) for(var key in field.values)
{ {
attrs.label = key; attrs.label = key;
attrs.onclick = field.values[key]; attrs.onclick = field.values[key];
} }
if (!attrs.label)
{
attrs.label = 'No "label=onclick" in values!';
attrs.onclick = function(){ return false; };
}
return !attrs.readonly; return !attrs.readonly;
} }
else if (this._type == 'customfields-list')
{
// No buttons in a list, it causes problems with detached nodes
return false;
}
else else
{ {
// Complicated case, a single custom field you get multiple widgets // Complicated case, a single custom field you get multiple widgets