Commit Graph

36692 Commits

Author SHA1 Message Date
nathan
7502749ef1 Avoid some more PHP8 errors
An error happened! (TypeError): Cannot access offset of type string on string
2021-10-14 08:59:05 -06:00
nathan
f8fd87cd1d PHP 8.0: Avoid fatal error "array_key_exists(): Argument #2 ($array) must be of type array, null given" 2021-10-14 08:58:57 -06:00
nathan
65b0a31aeb Fix expansion broken in ddddc5ba05
Caused export field checkboxes in new definition to not keep their value
2021-10-14 08:58:49 -06:00
Hadi Nategh
3317cc735a PHP8: fix error Undefined constant "status" 2021-10-14 15:38:57 +02:00
Hadi Nategh
894ebe2f51 PHP8: fix lots of warnings 2021-10-14 15:38:48 +02:00
Hadi Nategh
ab8a7d4c23 Remove none existing mail connectionTimeout preference. Fixes warning of Undefined array key 'connectionTimeout'. 2021-10-14 11:36:35 +02:00
Ralf Becker
60536222ce fix PHP 8.0 error forwarding mail as attachment (calling count on null) 2021-10-14 09:41:53 +02:00
Ralf Becker
e36ad76b80 fix wired PHP 8.0 error stalling calendar-multiget REPORT from CalDAV
str_replace() returns "Array" as value, if a multidimensional array given as 3rd parameter: https://3v4l.org/budKH
2021-10-14 08:57:21 +02:00
Ralf Becker
ccadef611d fix PHP 8.0 error when converting an InfoLog into a ticket
Cannot access offset of type string on string
Also add line and file to our non-json exception handler, for easier identifying the problems
2021-10-14 08:08:34 +02:00
Alexandros Sigalas
fdd275c605
Tabs of tabwidget, added onClick and ondDblclick events (#109)
* Tabs of tabwidget, added onClick and ondDblclick events

* OnClick and ondDblclick events on Tabs of tabwidget, parse functions only once.
2021-10-13 08:33:37 -06:00
Hadi Nategh
2d7aed2f4b Fix error "Non-static method Merge::get_all_ids() cannot be called statically" 2021-10-12 12:57:01 +02:00
Ralf Becker
d51d0eee83 fix a bunch of PHP Warnings 2021-10-12 11:51:56 +02:00
Ralf Becker
0f4abf8606 fix PHP 8.0 TypeError:
- array_combine(): Argument #1 ($keys) must be of type array, null given
- count(): Argument #1 ($value) must be of type Countable|array, null given
2021-10-12 11:44:51 +02:00
Ralf Becker
c844a47889 fix PHP 8.0 error: Undefined constant "EGroupware\Api\Contacts\cat_id" 2021-10-11 18:41:03 +02:00
Ralf Becker
a427b5d5c8 fix PHP 8.0 TypeError: when exporting multiple users
Argument 1 passed to EGroupware\Api\Accounts::username() must be of the type int or null, array given
2021-10-11 18:34:46 +02:00
Hadi Nategh
43806f3e39 Fix account selection for category owner field 2021-10-11 16:50:17 +02:00
Ralf Becker
a437f119ad fix PHP 8.0 error reading identity "new", when trying to create a new identity 2021-10-11 15:10:51 +02:00
Ralf Becker
389b66bedf fix PHP Warning: Illegal string offset 'tmp_name' 2021-10-11 14:03:09 +02:00
Ralf Becker
ccdedcce6d fix PHP Warning count(): Parameter must be an array or an object that implements Countable 2021-10-11 13:59:00 +02:00
Ralf Becker
43b80650b4 fix an other PHP 8.0 Error: Non-static method EGroupware\Api\Db::get_column_attribute() cannot be called statically 2021-10-11 13:23:42 +02:00
Ralf Becker
88a67d7442 fix PHP 8.0 TypeError: array_keys(): Argument #1 ($array) must be of type array, null given 2021-10-11 13:20:05 +02:00
Ralf Becker
fdc5421561 fix PHP 8.0 Error: Non-static method EGroupware\Api\Db::get_column_attribute() cannot be called statically 2021-10-11 13:15:59 +02:00
Ralf Becker
8485a1ea04 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-10-11 12:43:41 +02:00
Ralf Becker
4581ad7e2b fix PHP 8.0 Error: calendar_boupdate::update(): Argument #6 ($messages) cannot be passed by reference 2021-10-11 12:37:27 +02:00
Ralf Becker
5756d8c6b2 also output file and line of exception for json requests 2021-10-11 11:26:38 +02:00
Hadi Nategh
8feac04979
Merge pull request #108 from asig2016/21.1_toolbar
Added preference_id and preference_app attributes to toolbar widget, …
2021-10-11 10:22:46 +02:00
Ralf Becker
d5654e8178 fix CardDAV error with DAVx5 caused by PHP 8.0 throwing an error instead ignoring it with a warning
PHP 8.0 ValueError: mb_convert_encoding(): Argument #3 ($from_encoding) contains invalid encoding "tf-"
current code expected Content-Type header to have charset enclosed in quotes, which it was not
2021-10-11 09:51:15 +02:00
Ralf Becker
2e1f6a983f output line and file of exception as trace not always contain it 2021-10-09 08:43:48 +02:00
Ralf Becker
30952b4f16 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-10-09 08:42:56 +02:00
Alexandros Sigalas
a1f4922506 Added preference_id and preference_app attributes to toolbar widget, to make usage in edit forms opened in framework tabs easier. 2021-10-08 17:38:42 +03:00
Ralf Becker
f21492632b an other chunk of PHP 8.0 Warnings fixed 2021-10-08 15:44:32 +02:00
Ralf Becker
1cfb7a8c6a fix PHP 8.0 error: array_keys(): Argument #1 ($array) must be of type array, null given 2021-10-08 14:59:19 +02:00
Hadi Nategh
fbfe937524 Accept mail externalImages with long url 2021-10-08 14:31:44 +02:00
Ralf Becker
867c000d99 fix Api\Accounts::username(): Argument #1 ($account_id) must be of type ?int, string given 2021-10-08 14:11:15 +02:00
Ralf Becker
e1997befe9 fix empty labels in application selection in ACL dialog 2021-10-08 13:26:17 +02:00
Hadi Nategh
7da0ae68e3 Revert strict comparison on mimeType 2021-10-08 13:05:54 +02:00
Ralf Becker
0812bfaa79 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-10-08 11:39:32 +02:00
Hadi Nategh
7d95139fa9 Fix error key(): Argument #1 ($array) must be of type array, null given 2021-10-08 10:31:48 +02:00
Ralf Becker
7de75f16c1 fix PHP 8.0 errors around ACL dialog and policy:
- bitwise AND operator gives TypeError if both values are neither a number nor a numeric string, eg: null, "run"
- Etemplate::setElementAttribute() must NOT be called before instantiating an Etemplate object, you will get fatal error otherwise, because no request object
2021-10-08 09:06:45 +02:00
Ralf Becker
ca00987fb2 fix PHP 8.0 Fatal error: Declaration of Api\Etemplate\Request\Session::read($id = null) must be compatible with Api\Etemplate\Request::read($id = null, $handle_not_found = true) 2021-10-07 18:40:15 +02:00
Ralf Becker
74433a6a32 fix PHP 8.0 "TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given" when creating a new directory 2021-10-07 18:31:38 +02:00
Ralf Becker
7525a9b186 fix not working preferences GUI after ddddc5ba05 2021-10-07 17:28:42 +02:00
Ralf Becker
a599f9390c fix TypeError: Argument 1 passed to EGroupware\Api\Accounts::username() must be of the type int, null given 2021-10-07 16:53:54 +02:00
Ralf Becker
088dab168c fix PHP 8.0 error "array_key_exists(): Argument #2 ($array) must be of type array, null given" when creating a category 2021-10-07 16:16:39 +02:00
Ralf Becker
542192ce6e fix PHP 8.0 error Illegal string offset
folder object need to be cast to string (folder name) as objects are not allowed as array keys
2021-10-07 12:37:32 +02:00
Ralf Becker
16d02a856c fix missing icons after previous commit 2021-10-07 11:57:43 +02:00
Ralf Becker
7a93814c25 fix PHP 8.0 error when deleting a Kanban card
- link deletion failed when link_id was "" as in PHP 8.0 "" < 0 --> gave the error
- link to card was never deleted as board_id is not stored in card
2021-10-07 10:44:59 +02:00
Ralf Becker
7c40fc0981 an other chunk of fixed PHP 8.0 Warnings 2021-10-07 10:16:09 +02:00
Ralf Becker
18a92797ad PHP 8.0 Fatal error: Declaration of timesheet_tracking::get_subject($data, $old) must be compatible with Api\Storage\Tracking::get_subject($data, $old, $deleted = null, $receiver = null) 2021-10-06 16:32:51 +02:00
Ralf Becker
9345152c98 fix PHP 8.0 errors: key(): Argument #1 ($array) must be of type array, null given
guarding key() from calling with null eg. $button = key($content['button']) --> key($content['button'] ?? []) or check before !empty($content['button'])
2021-10-06 16:12:49 +02:00