Commit Graph

1700 Commits

Author SHA1 Message Date
Ralf Becker
84845d05b5 Fix PHP 8.0 Fatal error: Unparenthesized a ? b : c ?: d is not supported 2021-03-21 21:46:10 +01:00
Ralf Becker
ab9c089f70 fix PHP 8 Fatal error Array and string offset access syntax with curly braces is no longer supported 2021-03-21 21:13:07 +01:00
Ralf Becker
52e8aff9ae fix PHP 8 Fatal error undefined constant EGW_API_INC 2021-03-21 21:10:37 +01:00
Ralf Becker
3e278b3bd3 fix PHP 8.0 Fatal error: Array and string offset access syntax with curly braces is no longer supported 2021-03-21 18:47:15 +01:00
Ralf Becker
ffc048d472 fix PHP 8.0 Fatal error unknown function get_magic_quotes_gpc 2021-03-21 18:27:09 +01:00
Ralf Becker
dac55616af fix PHP 8.0 Fatal error 2021-03-21 18:25:14 +01:00
Ralf Becker
eb2b3943d7 fix Db errors with PHP 7.4+
caused by private $this->app not stored in session when Db\Depricated was instaciated
also move $GLOBALS[egw]->ADOdb to a static class var to fix session restore order caused $GLOBALS[egw] not yet restored giving a warning
2021-03-21 17:39:34 +01:00
Ralf Becker
b79971a1e9 set columns to search for phoneSearch for non-SQL backends too 2021-03-21 12:56:59 +01:00
Ralf Becker
fc50aa6312 phonesearch: LDAP or AD backend only search for local part hopefully stored without any formatting 2021-03-21 10:39:26 +01:00
nathangray
ce17d087c1 Fix hidden upload share link would not work for logged in user that was not share owner 2021-03-17 11:34:09 -06:00
nathangray
c21af32c1b Fix hidden upload share link would not work for logged in user 2021-03-17 11:17:06 -06:00
nathangray
47d2f433d6 Fix missed fstab mount kept unmounted shares around 2021-03-16 11:38:44 -06:00
Ralf Becker
06907d040b fix hidden upload sharing incl. use of multiple share-links in tabs 2021-03-16 15:03:15 +02:00
Ralf Becker
2aff05757e fix home-directories where created with wrong permissions, as Vfs::$is_root was wrongly evaluated 2021-03-15 11:41:53 +02:00
nathangray
1ffde3b692 Change global sharing variable to be a list of shares in use, indexed by token. This should resolve the issues with multiple shares being accessed in the same session. 2021-03-11 17:00:16 -07:00
nathangray
ba84d3170d Api: Improve handling of accessing multiple shares (Collabora or directory) in new tabs while logged in 2021-03-11 09:50:12 -07:00
Ralf Becker
fcc5c80244 match tel_assistent last, as it moves contacts to the end of the search result 2021-03-10 09:14:30 +02:00
Ralf Becker
dc41db9741 fix reverted regular sort order 2021-03-09 20:57:39 +02:00
Ralf Becker
646a04630d sort assisten phone matches to the end of the list 2021-03-09 20:49:12 +02:00
Ralf Becker
a10b772516 fix PHP Notice: Undefined offset 2021-03-09 09:19:15 +02:00
nathangray
8063d65303 Check that some things exist before trying to use them 2021-03-05 09:30:02 -07:00
nathangray
95f84454be Silence some warnings & debug 2021-03-05 09:13:12 -07:00
Ralf Becker
58ae23c74c allow "app.<appname>.<method>" in link registry and use it to open CRM view 2021-03-04 11:50:13 +02:00
nathangray
a8278b37ff Fix editable link opened by original user in new tab gave "Requested resource '/' does NOT exist!" 2021-03-03 14:23:42 -07:00
Ralf Becker
89d6dc8650 Fixing the fix Undefined constant DateTime 2021-03-02 10:25:11 +02:00
Ralf Becker
b1af8449fd Fix ErrorException: Object of class EGroupware\Api\DateTime could not be converted to string
It's happening as we removed __toString method from Api\DateTime to allow again direct comparing with comparison operators
2021-03-02 09:37:43 +02:00
Ralf Becker
a41865209c stop SQL error, when using account-type with name2id($name, "person_id", "u") 2021-02-26 21:57:11 +02:00
Hadi Nategh
2a2f0bf390 Keep darkmode state in serverside session too. Fix darkmode state in egroupware iframes. 2021-02-24 12:22:27 +01:00
Hadi Nategh
a67e433396 WIP Mobile and Compact theme styling improvements:
- Fix logout button not displayed in Compact theme
2021-02-23 16:21:38 +01:00
Ralf Becker
319c0e6af4 use CRM view preference in CTI 2021-02-19 21:30:50 +02:00
Ralf Becker
fdecefebd4 fix exception when trying to store a DateTime 2021-02-19 21:30:50 +02:00
Ralf Becker
e1b9d993a5 missing phoneSearch commit to only search certain numbers, if specified and fix for a typo causing a warning 2021-02-19 21:30:50 +02:00
nathangray
c319478816 Fix readonly shares were mounted as writable when shared to another user 2021-02-16 16:14:32 -07:00
Ralf Becker
e54aebebca xml tags must not include undeclared namespaces like: <link-entry:infolog
Reinstating "throw an exception on XML errors in eTemplates for easier fixing"

This reverts commit 18b7d9311c.
2021-02-16 21:52:40 +02:00
nathangray
4b6551c5a3 - Fix missing quote when updating shares with VFS changes
- Fix user delete entry search for single user
2021-02-16 11:53:32 -07:00
nathangray
18b7d9311c Revert "throw an exception on XML errors in eTemplates for easier fixing"
This reverts commit 81b4737710.
2021-02-16 11:39:38 -07:00
Ralf Becker
81b4737710 throw an exception on XML errors in eTemplates for easier fixing 2021-02-16 17:38:47 +02:00
Ralf Becker
57d5176080 remove non-digits and only search phone-numbers in phoneSearch 2021-02-15 21:28:39 +02:00
Ralf Becker
ee6a74a40f fixed CRM view opened for id=0 2021-02-15 17:20:17 +02:00
Ralf Becker
31b7db5bbe some more logging 2021-02-15 16:19:53 +02:00
Ralf Becker
a64590d3db moving opening of CRM view code into Contacts class 2021-02-15 15:11:24 +02:00
Ralf Becker
10fd1cd76b fix typo 2021-02-14 17:55:04 +02:00
Ralf Becker
2291cc8df0 WIP incomming CTI / open CRM view when phone rings 2021-02-14 17:46:08 +02:00
Ralf Becker
cfc7c1cbdf some more tolerant searches to find numbers in EGroupware GmbH database 2021-02-14 14:52:33 +02:00
Ralf Becker
f8ec1618d9 * Adressbook: phone-number in search only returns contacts having that (normalized) number 2021-02-14 14:06:21 +02:00
Ralf Becker
c37581f43c * EPL/mail: support SpamTitan REST API to manage spam, requires an API token 2021-02-08 17:31:49 +02:00
nathangray
98d5e86121 Avoid some warnings 2021-02-05 08:57:48 -07:00
Ralf Becker
04f4a327c2 implement date-duration select_unit="false" to show durations like "0:01:20" 2021-02-05 15:57:59 +02:00
nathangray
be9fcea5c5 Etemplate: Make sure all attributes get expanded 2021-02-04 14:48:22 -07:00
Ralf Becker
15c72f284f change client-side to only deal with a duration converted server-side from an end-datetime or a duration like "+123seconds" 2021-01-28 19:53:14 +02:00
Hadi Nategh
e98a8b372e Only apply darkmode preference on top level window for initiation because the rest is supposed to get set from client-side state 2021-01-28 18:03:27 +01:00
Ralf Becker
5b4a436ab3 countdown: convert datetime server-side into a duration to avoid problems with wrong time or timezone on client 2021-01-28 16:02:38 +02:00
Ralf Becker
69b33e9288 make countdown a value-widget to get automatic timezone handling by date widgets beforeSendToClient method 2021-01-28 12:08:29 +02:00
Ralf Becker
511325570a fix empty accounts addressbook after 20.1.20210125 update 2021-01-26 12:51:33 +02:00
Ralf Becker
1259ae8d04 More automatic timezone handling schema for new code (hopefully not breaking existing code):
1. SO converts all timestamps to Api\DateTime objects using Api\DateTime::server2user($ts, 'object')
 - Api\Storage and Api\Storage\Base class do that automatic if using 'object' as $timestamp_type constructor parameter
 - if using just Api\Db you need to iterate over your selects manually and apply Api\DateTime::server2user($ts, 'object')
 - timestamps are store in DB in server timezone and above conversation honors that and additionally set the user TZ
2. Rest of the app should keep all timestamps as Api\DateTime objects
 - direct comparison works for Api\DateTime (and PHP \DateTime) as __toString() method automatic converts to UTC timestamps
 - do NOT convert them to timezone-less timestamps and no further timezone conversation needed for output with eTemplate
3. eTemplate2 converts automatic to user timezone for displaying dates and times
 - you need to use <date-time ... data_format="object"/> to get Api\DateTime objects back from eTemplate!
4. Api\Db converts automatic to server timezone when quoting DateTime objects for integer or timestamp columns
5. only output other then eTemplate might need to set a timezone different from the user TZ before calling $ts->format()
2021-01-26 11:16:42 +02:00
Ralf Becker
8425f380fe some fixes for int/float widget: server-side was not expanding min/max attribute and client-side considers empty min/max attr as 0 2021-01-22 17:24:55 +02:00
Ralf Becker
fe320938e5 document EGroupware timestamps and remove own __toString() method to be able to compare objects 2021-01-22 15:18:39 +02:00
Ralf Becker
3eaab63bfa new $output_mode=5 for exec to allow validating client-side created templates, see SmallParT\\Questions\\ajax_answer() 2021-01-19 14:55:27 +02:00
Ralf Becker
b892c54797 allow to format link-registry entries "add", "edit", ... as "url" parameter for actions 2021-01-14 15:59:03 +02:00
Ralf Becker
e588d63291 allow *-wildcard in egw:uses path eg. "/smallpart/js/overlay_plugins/*.js" 2021-01-03 21:06:45 +02:00
Ralf Becker
5bcbde4f88 * LDAP/Addressbook: use accounts filter from setup for accounts addressbook too 2020-12-29 19:37:21 +02:00
nathangray
0a95588642 Preference needs this to not get changed here, otherwise validation doesn't find what it needs 2020-12-22 11:54:31 -07:00
nathangray
6af3e37bed * Etemplate: Add context menu action on linked files to copy them somewhere else
Also, update vfsSelect to use request(), so it processes the additional stuff in response so we can have a success message.
2020-12-21 13:53:24 -07:00
nathangray
93b64235a2 Etemplate: Fix customfield prefix attribute length assumption 2020-12-17 10:07:50 -07:00
Hadi Nategh
467a9cad42 WIP darkmode theme: Implement darkmode switch for mobile view 2020-12-17 17:20:04 +01:00
nathangray
8910983c8e Etemplate: Fix for some attributes not getting set 2020-12-17 09:17:38 -07:00
Ralf Becker
b8edbd159e guard against mail account looses all accounts it is valid for 2020-12-17 08:31:39 +01:00
Hadi Nategh
f21ac58c87 Introduce dark/light mode theme switch into framework 2020-12-15 20:24:25 +01:00
Ralf Becker
5fae437a52 * Setup: fix no accounts found for SQL instances
in setup without an active user, no grants existed, seemed no problem before, maybe caused by contact sharing
2020-12-15 18:10:37 +01:00
Hadi Nategh
cde6c10e05 Add Segoe font family into HTMLEditor 2020-12-09 13:17:37 +01:00
Ralf Becker
93fb74503d limit number of returned rows on link query by default to 100 2020-12-07 14:31:10 +01:00
Hadi Nategh
c8020e6456 Do not query server if there's no actual taglist query, fix fatal error "Memory exhaustion" 2020-12-07 10:58:42 +01:00
nathangray
1dcdac1fe1 Try to avoid some "Illegal offset type" warnings 2020-12-02 11:07:24 -07:00
Ralf Becker
aa62a5ea3e also run Egw::__destruct() explicit for notifications 2020-11-22 11:50:20 +01:00
Ralf Becker
d759e4b5a9 * Tracker: fix empty notification mail, if ticket was opened by following a link in notification mail 2020-11-21 18:55:39 +01:00
nathangray
15084c8439 Etemplate: Use the actual template attribute if set for action processing, instead of always using the deprecated options attribute 2020-11-12 14:41:23 -07:00
nathangray
0fcfad04b4 Etemplate: Match server-side grid row namespacing to client-side
Client side does not open a new data perspective if row has an ID, server now doesn't to match.  Fixes grids with row IDs lost their data on submit.
2020-11-05 13:41:36 -07:00
nathangray
10b98897d2 Etemplate: Fix sub-templates not expanded and children not processed if id is set but does not expand 2020-11-04 16:10:09 -07:00
nathangray
b3ed6372f7 Etemplate: Fix unwanted row reset if box had no ID 2020-11-04 12:53:29 -07:00
Ralf Becker
f6aad0cd46 allow to filter by (not) shared and add groups to shared-with filter 2020-11-04 16:05:41 +01:00
Hadi Nategh
c118f39f89 Fix CRM View sidebox content gets disappeared after directly reopening a contact 2020-11-04 11:37:18 +01:00
Ralf Becker
378b3c6eef enable unshare action also when shared-with column is shown and fix some bugs arround unsharing and resharing 2020-11-02 12:56:00 +01:00
Ralf Becker
a3b17c5db7 display shared-with in addressbook column and allow to use it as filter 2020-11-02 12:05:13 +01:00
Ralf Becker
47c8897642 fix typo and missing Accounts.php 2020-10-30 13:02:19 +01:00
Ralf Becker
3c956d0144 * Saml/Shiboleth/SmallPART: allow to use affiliation attribute to sync with Teachers group 2020-10-30 11:44:49 +01:00
Ralf Becker
ac64ae51aa * Ads/CardDAV/Addressbook: fix exception / HTTP status 401 when trying to delete an not existing distribution list 2020-10-29 20:29:58 +01:00
nathangray
1eae5d3780 Etemplate: Fix for Box not properly handling namespaces, now working for submit too 2020-10-28 09:51:55 -06:00
Ralf Becker
47da0f9bf8 * Addressbook: allow to configure sending fax via email by replacing the number with an email address 2020-10-28 13:30:28 +01:00
nathangray
5566a9d971 Etemplate: Fix for Box not properly handling namespaces 2020-10-27 10:29:46 -06:00
Ralf Becker
b8409a479e changes to implement policies on contact sharing 2020-10-26 10:44:40 +01:00
Ralf Becker
64f335eeb7 fix not working writable sharing 2020-10-24 14:45:01 +02:00
Ralf Becker
fa80d4c1f9 * ActiveDirectory/Mail: fix groups as distribution lists 2020-10-22 18:06:24 +02:00
Hadi Nategh
7d1cd4c12c WIP Multitabs:
- Fix wrong ids generated for sideboxes
- Fix tab header refresh
2020-10-22 13:52:17 +02:00
nathangray
b1275dd2da Accept the same class naming as index.php 2020-10-21 13:19:02 -06:00
nathangray
316adfab5e Fix some bugs in hidden uploads
- Creating the share couldn't handle sqlfs://user@path style paths
- UI namespace issues
2020-10-21 09:13:37 -06:00
nathangray
5bf4d4866f WIP on sharing prompt to ask about mounting new share 2020-10-20 16:47:26 -06:00
Ralf Becker
7c9e1c98ec fix umount to deal with user-specific mounts too 2020-10-20 20:16:57 +02:00
Ralf Becker
9eae0333ad allow for user specific mounts 2020-10-20 20:13:36 +02:00
Ralf Becker
496c168db4 * Api: setting configured server-timezone for the databases connection, to fix cases were they do not match 2020-10-19 17:25:07 +02:00
Ralf Becker
3292e478b6 creating a new dir from filemanager-select dialog always gave an error 2020-10-19 13:00:05 +02:00
Hadi Nategh
72769e7a43 * HTML Editor: fix bug in editing uploaded image 2020-10-19 11:14:52 +02:00
Ralf Becker
37be9f40d0 WIP contact sharing: context menu to share and filter for shared contacts 2020-10-16 21:34:42 +02:00
Ralf Becker
884ae7fe94 fix error creating new accounts 2020-10-16 13:32:17 +02:00
Ralf Becker
ff91be903a sharing ACL: need explicit new ACL or edit rights, to share into an addressbook 2020-10-15 13:03:14 +02:00
Ralf Becker
6b57ddac00 only save sharing information if its given, eg. not the case for CardDAV 2020-10-15 13:02:32 +02:00
Ralf Becker
9567a1fed3 fix contacts shared with a user are not visible in his personal AB, but when all addressbooks selected 2020-10-15 11:35:53 +02:00
nathangray
ea41ab8e77 Api: Add charset parameter to tidy->repairString() to avoid mangling some non-ascii characters when merging into document 2020-10-14 14:53:37 -06:00
Ralf Becker
175d94f3e3 * Api: detect if framework data is missing for popups too and redirect to cd=popup to load it 2020-10-14 17:31:36 +02:00
Hadi Nategh
43600426c7 * Api: Add table button into html editor's toolbar 2020-10-14 11:05:51 +02:00
nathangray
05ee7eba37 Avoid some 'array_key_exists() expects parameter 2 to be array' warnings by checking first 2020-10-13 15:20:33 -06:00
Ralf Becker
1f7ce98c50 WIP contact sharing 2020-10-13 16:54:35 +02:00
Ralf Becker
4886583cc1 change sharing to allow mounting shared into existing user sessions
without the need to destroy the session, if the sharee is a different user

This is accomplished by keeping the sharee in the stream context / attribute of the vfs class(es) instead of static Vfs::$user.
Later is still used for the current user - identical to egw_info[user][account_id].

This commit / merge of the vfs-context feature branch also added the abilty to mount WebDAV sources, eg. a sharing link from an other EGroupware instance
or any WebDAV server
2020-10-08 11:24:34 +02:00
Ralf Becker
3ca5c80534 some ideas/todos 2020-10-07 11:45:13 +02:00
Ralf Becker
b960a24c32 implement UDM_REST_INSECURE environment variable to UCS appliance with no valid cert yet 2020-10-07 10:22:27 +02:00
nathangray
151889b39c Api: Move list of common merge placeholders into parent class to reduce duplication, add link/<format> options 2020-10-06 10:56:08 -06:00
Ralf Becker
77b1c0ac33 * Admin: fix session list did NOT show interactive sessions, if push is used 2020-10-06 11:59:19 +02:00
Ralf Becker
094a60d7f7 doc fix 2020-10-06 11:52:29 +02:00
nathangray
81cdf759a3 Api: Fix links got escaped when put into mail templates 2020-10-05 14:14:54 -06:00
nathangray
baebf56fb2 Merge: Fix {{link}} placeholder was incorrectly wrapped in HREF tag. Use {{link/href}} for that now. 2020-10-02 12:37:37 -06:00
Ralf Becker
7db25dce5e * Admin: push server test to diagnose problems and improved recovery from failed requests / network problems 2020-10-02 20:28:02 +02:00
Ralf Becker
55b615af5f config got "lost" after deleting the cache, caused by it being automatic unserialized 2020-10-02 08:38:51 +02:00
Hadi Nategh
7f4535cf1d WIP multitabs and CRM view 2020-09-30 13:19:36 +02:00
Ralf Becker
7fa1e7cd80 * ActiveDirectory: fix unwilling to perform error when saving an account 2020-09-27 10:02:22 +02:00
Hadi Nategh
acbd23a60a * Mail: Add custom html toolbar settings in mail site-configuration in order to be able to add/remove certain actions only for mail-compose dialog. 2020-09-25 14:17:29 +02:00
Hadi Nategh
4bf65486ef WIP of framework's multitab implementation 2020-09-23 16:55:35 +02:00
nathangray
b5ef5126c6 - Send push messages for account delete
- Send actual push type for contact changes
- Handle push deletes for admin
2020-09-22 13:53:08 -06:00
Ralf Becker
8df5371ffa fix wrong OID for mail attribute 2020-09-22 19:21:14 +02:00
nathangray
94a57d6902 Api: Some tests for filesystem 2020-09-16 11:48:40 -06:00
Ralf Becker
da27403b1b * eSyncPro: fix SQL error in device list 2020-09-16 16:45:01 +02:00
Alexandros Sigalas
55c9487517 Fixed: Declaration of EGroupware\Api\Mail\Smime::extractSignedContents($data) should be compatible with Horde_Crypt_Smime::extractSignedContents($data, $sslpath = NULL) 2020-09-15 08:36:17 +02:00
Ralf Becker
612a991c85 fix illegal string offset 2020-09-15 08:30:45 +02:00
nathangray
372eadcff3 Api: Fix fstab overlap when accessing a share while logged in 2020-09-10 11:11:39 -06:00
Ralf Becker
3ee7574294 * Authentication: allow using multiple backends, even same backend multiple times with different configuration 2020-09-10 17:12:53 +02:00
Ralf Becker
ca9526988f missing file from #9f9cce8 fix account-selection type groupmembers 2020-09-10 11:26:14 +02:00
Ralf Becker
9f9cce88b2 * ActiveDirectory: fix account-selection type groupmembers (applies only to non-admins!) and ignore Domain Users group
not setting caseIgnoreMatch for sorting, as its not supported for Windows ActiveDirectory
2020-09-08 15:29:51 +02:00
Ralf Becker
5afe7ddbca * ActiveDirectory: support huge directories by using server-side sorted and limited queries and no caching in session 2020-09-05 13:11:26 +02:00
Ralf Becker
7614e3e851 * ActiveDirectory: users not found when search starting with A-F and fixed attribute-names: company, department, ... 2020-09-03 15:47:07 +02:00
Ralf Becker
c3000beb5f * ActiveDirectory: implement addtional user or group filter 2020-09-02 14:14:11 +02:00
Ralf Becker
eb812dad01 * PostgreSQL: fix SQL error opening ProjectManager
caused by exploding SQL expression by comma --> keep colums as array, to not have the need to explode it
2020-09-01 10:24:46 +02:00
Ralf Becker
4f2ad476a6 * Calendar/CalDAV: config to replace email-domain eg. for a migration 2020-08-14 18:03:44 +02:00
Hadi Nategh
50a34d9c42 Make sure path is not empty before using it, fixes error "an error happened! File '' is not an absolute path!" 2020-08-14 11:06:06 +02:00
Ralf Becker
a9dc772e14 * Mail: fix not shown folder tree for some Cyrus servers
since 20.1 uses Horde_Imap_Client::MBOX_ALL_SUBSCRIBED to query subscribed and unsubscribed folders in one command
2020-08-13 18:51:24 +02:00
Ralf Becker
a14a21fa49 * Tracker/Notifications: send mail after response to user and push errors 2020-08-01 15:10:07 +02:00
Ralf Becker
3972abdf52 * Notifications: taking push server into account for checking user is online for popup or email notifications 2020-07-31 17:50:01 +02:00
Ralf Becker
0e3143d45d fix SQL error in ranking caused by automatic added ambigous column which app code had already aliased "$table.$col AS $col" 2020-07-31 13:39:05 +02:00
Ralf Becker
33e88d25ae * Preferences: use push to ask every affected client to reload preferences, if affected 2020-07-31 09:47:49 +02:00
nathangray
5b5bb12d02 Calendar exception no longer needed 2020-07-27 10:14:00 -06:00
Ralf Becker
2a500333ed explicit call Egw::__destruct() to fix calendar notifications not send, if dialog is Saved not Applied 2020-07-27 16:08:00 +02:00
Ralf Becker
ca73a54d89 * Security: allow to configure SameSite cookie attribute 2020-07-27 14:03:48 +02:00
Ralf Becker
074b884133 calendar non-list views need refresh calls, even using push 2020-07-27 09:45:37 +02:00