Commit Graph

5038 Commits

Author SHA1 Message Date
nathan
181546cdb5 Fix customfield selects so if rows > 1, we set multiple=true 2022-09-26 11:38:36 -06:00
nathan
9644e4b1df Avoid double-parsing nm row if for some reason grid has too many rows.
Should fix missing initial data, but I'm still not sure exactly why row grid can have too many rows.
2022-09-26 10:55:32 -06:00
Hadi Nategh
7ba571b710 Fix some styling issues in edit avatar dialog 2022-09-26 15:48:45 +02:00
Hadi Nategh
2ed1a12617 Fix topmenu dropdowns click handler 2022-09-26 13:36:10 +02:00
ralf
3c79bd4345 WIP timesheet timer
just a prototype for now, no persistence beside the session to test reloads
2022-09-26 08:54:05 +02:00
ralf
fe4d0dbbe3 json requests now close the PHP session immediately again and reopen it, if there was an update to the session
this allows to run more PHP requests in parallel
2022-09-24 15:50:44 +02:00
ralf
84d65bcf3b there is currently no avatar for groups, no need to ask server about it 2022-09-24 14:44:42 +02:00
ralf
9ab4c69050 only update darkmode pref, if necessary 2022-09-24 14:27:17 +02:00
nathan
086d92e957 Et2Select: All selectboxes now stop scroll event from bubbling to prevent parent (sidemenu) from scrolling too 2022-09-23 10:54:02 -06:00
nathan
171c9c02cb Pressing escape while in search now closes dropdown 2022-09-23 10:40:16 -06:00
nathan
074a03f2ec Include bad email address in validator message 2022-09-23 10:08:31 -06:00
nathan
00c9550465 Fix selects without empty_label were not allowed to be empty in some cases, even without required=true
For example select-account multiple=true, or customfield select-account with rows > 1 would give error "'' is NOT allowed ('not found')"
2022-09-23 09:39:50 -06:00
nathan
d133683272 Don't apply et2_required class to parent table cell 2022-09-23 08:51:57 -06:00
nathan
91bd7d5a43 Et2Button: Fix disabled was still hiding the event even if hideonreadonly was false 2022-09-22 15:20:21 -06:00
nathan
bea34ad403 Fix adding a freeEntry did not trigger change event 2022-09-22 15:18:34 -06:00
nathan
4454f350b2 Fix some more validation bugs
- Fix error if widget did not have a feedback slot or a '#help-text' element
- Fix copy/paste error scrolling to wrong widget
2022-09-22 11:43:29 -06:00
nathan
5a8f7c3c70 More fixing of missing search options / tags
Fixes new free entries don't show up after removing a free entry
2022-09-22 11:15:25 -06:00
nathan
0424836ba8 If widget fails validation during submit check, scroll it into view 2022-09-22 09:20:50 -06:00
nathan
8da8c14a00 Et2SelectEmail: Change multiple default to false to match other selects 2022-09-22 08:59:31 -06:00
ralf
6c9d6fd13f only remove size attribute from input like widgets: textbox, number, url-*, vfs-*, leave it for all others like *avatar 2022-09-22 13:12:56 +02:00
nathan
2952df2799 Et2Select + SearchMixin: Fix some bugs with display and selecting entries
- Fix clicking on text while editing triggered re-display
- Avoid unneeded node re-creation when editing free entry, handle empty value as removal
multiple=true:
- Fix clearing search removed previously selected remote results
- Fix adding a free entry did not move search down, covering the new value
multiple=false:
- Fix search & edit inputs were shown at the same time
- Fix edit free entry always took over making it impossible to search
2022-09-21 17:13:29 -06:00
nathan
e6ce33b153 Fix invalid fields were not blocking submit 2022-09-21 09:56:15 -06:00
nathan
d9cc794836 Don't bother to validate empty fields if they're not required
Fixes Et2SelectEmail complaining that empty strings are not valid email addresses
2022-09-21 09:05:51 -06:00
Hadi Nategh
8cc14a9919 Fix attachment button is being overlapped by searchbox in vfs select dialog 2022-09-21 16:49:31 +02:00
Hadi Nategh
ca0b17de7f Fix edit/delete buttons are not clickable on editable avatar 2022-09-21 11:15:14 +02:00
nathan
8ce438f757 Add translation from Birgit 2022-09-20 11:44:14 -06:00
nathan
159a370da6 Fix more than one anonymous shares gave error / BasicAuth prompt
First one was successful, but subsequent anonymous shares in the same browser failed
2022-09-20 11:33:16 -06:00
nathan
e03fea2e9b Et2Date: Fix required validation message was always shown after changing a required date
Some missed changes after moving from Lion
2022-09-20 10:44:28 -06:00
nathan
7dd0165cd2 Et2Select + search: Fix position adjustment did not work in all cases
Subsequent searches did not give space for searchbox
2022-09-20 10:07:36 -06:00
nathan
66368c6d3a Et2Select + search: Adjust dropdown position based on if it opens up or down 2022-09-20 09:43:25 -06:00
nathan
79b6cef5fd Switch egw.user(..., async=true) to always return a Promise for consistency
Switch Et2ButtonTimestamper to use egw.user(...,async=true)
2022-09-20 08:05:59 -06:00
Hadi Nategh
34d9297fc1 Do not set toolbar buttons to readonly 2022-09-20 14:44:16 +02:00
ralf
1260203755 setting minimum version for 22.1 to PHP 7.4, recommended and maximum version to PHP 8.1 2022-09-20 13:53:07 +02:00
Hadi Nategh
c18aabb100 Fix toolbar's admin icon size 2022-09-20 12:46:26 +02:00
Hadi Nategh
aba4edc70a Add svg version for BD icon 2022-09-20 10:29:26 +02:00
nathan
f43b641127 Implement readonly textarea as description 2022-09-19 13:28:20 -06:00
nathan
606e2688d4 Et2SelectEmail: Do not create image in tag, Et2EmailTag uses CSS for image
Fixes doubled image
2022-09-19 09:23:23 -06:00
ralf
17ee3e7aaf correctly handle irregular alias time_or_date (of date-time_today) and just menupopup both used in mobile view 2022-09-18 08:54:39 +02:00
ralf
a9f8e6fcd5 set correct default search-url for taglist-email 2022-09-17 09:56:57 +02:00
nathan
1deeee207f Better way to show "no suggestions" indicator, works with local options now too 2022-09-16 11:17:06 -06:00
nathan
12ab9b72a1 Fix Et2SelectEmail search queried wrong URL
broken by 5a20f5965e
2022-09-16 10:38:37 -06:00
nathan
30c3000e87 Et2Select fixes
- Search with no results blocked any futher searches from displaying results
- Only show "no suggestions" after searching
2022-09-16 10:20:47 -06:00
ralf
99f1984b48 Changelog for 21.1.20220916 2022-09-16 14:02:04 +02:00
ralf
5dcc670ac0 nicer way to set current Vfs user and also not overwriting the default context 2022-09-16 09:33:09 +02:00
ralf
0f376ae6df * LDAP/AD/OpenID Connect: fix error creating tokens with profile claim, if user has a picture 2022-09-16 09:14:38 +02:00
ralf
c59b5a7a6e document how to test LDAP/AD behavior 2022-09-16 09:13:01 +02:00
nathan
9a036b1dfe Et2Select: Fix "required" styling did not show in a better way
Previous method (38e8df2) made widget entirely transparent
2022-09-15 15:26:06 -06:00
nathan
a3e2850b05 Send info to open popups to inform user that main window has been reloaded. 2022-09-15 15:14:16 -06:00
nathan
38e8df223d Et2Select: Fix "required" styling did not show 2022-09-15 12:36:31 -06:00
nathan
3616fe9df0 Add "hasValue" class for input widgets that have a value, and use that class to hide required styling when the widget has a value 2022-09-15 12:28:49 -06:00
nathan
2f97c28a5f Better styling for all calendar popup headers
More space for month, make it as similar as possible between inline & popup
2022-09-15 11:18:44 -06:00
nathan
49829fbbcc Fix OS copy using navigator.clipboard still showed "Use Ctrl+C..." 2022-09-15 09:23:16 -06:00
nathan
c8b6a5760b Et2Select: Re-add accidentally removed chunk that sets initial value when initial value is an array
Fixes mail preview didn't show to/from addresses
2022-09-15 08:49:36 -06:00
nathan
1b72eb4a00 Revert "Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content"
This reverts commit 0287e06df2.
2022-09-15 08:30:50 -06:00
ralf
0287e06df2 Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content
This reverts commit 56eb4d64ac.
2022-09-15 12:56:12 +02:00
Hadi Nategh
5e7a6cfef7 Fix mail tree drop hover class sometimes not being removed from hovered once nodes 2022-09-15 12:40:49 +02:00
nathan
a20a85309b Better styling for inline calendar (calendar sidebox) header
tighten up vertical spacing
2022-09-14 16:53:31 -06:00
nathan
048fc8c8c0 Better styling for inline calendar (calendar sidebox) header 2022-09-14 16:43:36 -06:00
nathan
56eb4d64ac Et2Search: Fix some UI bugs
- Fix missing loading spinner while searching
Clear button was in the way, now hiding clear button when displaying the spinner

- Fix searching for the same thing twice displays no results the second time
repeat() and map() directives were not putting the DOM nodes back in, worked around by using a temp div to render into.  There were some lifecycle mistakes as well leading to collisions & re-doing.
2022-09-14 15:47:36 -06:00
ralf
1989e1a949 fix PHP 8.1 makes all schema errors fatal, change that back to previous behavior, to ease updates 2022-09-14 14:45:09 +02:00
Hadi Nategh
3d7df8e566 WIP Universal Access preference:
- Implements textsize preference
2022-09-14 12:41:09 +02:00
Ralf Becker
872aeaa95f pending translations from our translation server 2022-09-14 11:08:00 +02:00
ralf
0c11d2fd59 fix OpenID scope "profile" gives error that it cant create /home//.tmp 2022-09-14 10:01:33 +02:00
ralf
5a20f5965e fix preprocessor to set default taglist autocomplete_url/searchUrl, if none is set and change autocomplte_params to searchOptions
an empty autocomplete_url is preserved, as it was used to disable autocomplete
2022-09-14 09:10:16 +02:00
nathan
cfbb74b83e Fix some Et2DateDuration bugs
- Duration did not validate correctly
- Validation errors were not actually shown
- Empty duration ('') did not work consistently
2022-09-13 13:00:25 -06:00
nathan
a847f25408 Show success message after copying to clipboard 2022-09-13 10:23:47 -06:00
nathan
b14a472814 Better specificity on the grid padding 2022-09-13 09:50:01 -06:00
nathan
9096c17348 Et2Select: Tabbing out of search field now closes the dropdown 2022-09-13 09:06:59 -06:00
Hadi Nategh
b6cfeaedf0 Fix some glitches in calendar 2022-09-13 13:52:42 +02:00
Hadi Nategh
44e2938d05 Fix avatar cropper gets closed right after uploading an image 2022-09-13 12:09:55 +02:00
Hadi Nategh
98584884b0 Fix avatar contactId attribute 2022-09-13 11:16:50 +02:00
ralf
d8d8429622 an other fix for 4c00b812ee fixing error when trying to reply 2022-09-13 10:17:59 +02:00
ralf
c00c6f9e07 readonly et2-select-mail caused error with 4c00b812ee eg. in mail.display 2022-09-13 09:15:55 +02:00
ralf
52cca3676e Revert "reinsert filtered <style></style> section at initial position"
It seems to lead to a significant higher memory usage and did NOT fix the problem it was supposed to fix (empty line above email after sending)

This reverts commit 4e0bb13571.
2022-09-13 08:24:11 +02:00
nathan
662ea62790 Calendar: remove most sidebox date customisations
Now using regular calendar header.  "Go" button and custom header styles removed. Changing the date in sidebox calendar immediately updates state.
2022-09-12 15:35:24 -06:00
nathan
4c00b812ee Fix edit inputbox covered new freeEntries 2022-09-12 12:48:21 -06:00
nathan
0ea32818c8 Fix Et2NumberReadonly didn't display its value in nextmatch row 2022-09-12 11:25:47 -06:00
nathan
43cce1940d Fix selecting search result does not display label
Infolog contact filter still filtered, but did not show label for selected search result.
2022-09-12 10:19:38 -06:00
nathan
671ec22243 Give all grids some padding between cells 2022-09-12 08:41:17 -06:00
Hadi Nategh
1489944d49 Fix category border styling 2022-09-12 15:16:04 +02:00
ralf
26824323e5 got mailing lists working again in mail compose using includeLists=true attribute
using "$list_name <$list_id@lists.egroupware.org>" instead of just integer ids for the list, thought et2-select-mail is NOT displaying the mailing-list icon, after a mailing-list is selected
2022-09-12 14:51:13 +02:00
Hadi Nategh
f7c8c09a4b Drop tutorials 2022-09-12 13:24:00 +02:00
ralf
e916dda8a6 disallow https-urls too 2022-09-12 12:50:31 +02:00
ralf
bf5389b02e * Mail/RichTextEditor: common preference "small paragraph" now changes return key to a line break instead of a paragraph (with margin) 2022-09-12 10:05:01 +02:00
nathan
217ae647e7 Fix historylog created editable versions of some widgets, triggering the dirty save warning 2022-09-09 12:04:23 -06:00
nathan
fb568a1b11 Give dialog grids some padding between cells 2022-09-09 11:03:14 -06:00
nathan
c2d6d646f1 Api: Fix copy to OS clipboard action stopped working
We now have clipboard API, when browser supports it
https://developer.mozilla.org/en-US/docs/Web/API/Clipboard
2022-09-09 09:30:12 -06:00
nathan
04feaff1d0 Avoid parse error that breaks load if string is passed as an object property 2022-09-09 08:35:20 -06:00
ralf
b13c1d97b4 fix PHP 8.x throws mysqli_sql_exception when it can not connect 2022-09-09 08:24:39 +02:00
nathan
9db38979ef Infolog: Move timestamper & encrypt buttons into tabs using slot and parentID
Also, fix parentId was inconsistently applied
2022-09-08 13:14:55 -06:00
nathan
f85de279c6 Fix some property bugs
- Parse values that should have been objects but came as strings
- Decode SearchMixin.searchUrl
2022-09-08 11:17:34 -06:00
ralf
4e0bb13571 reinsert filtered <style></style> section at initial position
no longer at the beginning as this can insert unwanted extra lines in mail, if signature contains a style block
2022-09-08 16:52:49 +02:00
Hadi Nategh
3435c475f5 Implement cursor position center for egw_tooltip 2022-09-08 16:16:34 +02:00
Hadi Nategh
79cec31989 Fix label of button overlaps outside its container if it gets squeezed enough 2022-09-08 12:47:11 +02:00
ralf
7b54b0f563 set correct return type 2022-09-08 11:30:20 +02:00
ralf
9f4fb1343d fix Mailvelope in infolog.edit 2022-09-08 11:27:02 +02:00
nathan
a10938ab2b Fix select account readonly did not properly show names with CSV 2022-09-07 15:12:06 -06:00
nathan
088280ceb5 Fix placeholders lists 2022-09-07 14:50:31 -06:00
nathan
509715d913 Better styling for long task results 2022-09-07 11:27:50 -06:00
nathan
3380b867b8 Fix some overlap styling issues with sub-headers
In particular, call list buttons and most date filters were overlapping the row count
2022-09-07 09:54:09 -06:00
nathan
0fb1f32152 Et2LinkEntry: If the app is changed, clear previous search results and focus the search field 2022-09-07 08:42:04 -06:00
nathan
151df0f76b Et2Select + search fixes
- Fix multiple=false had gap between widget and dropdown
- Add clearSearch() to clear the (remote) search results
2022-09-07 08:40:46 -06:00
Hadi Nategh
921c2905ad Restyle date widget today's button 2022-09-07 13:45:53 +02:00
Hadi Nategh
a35b7e578b Revert accidentally removed condition on status 2022-09-07 12:06:38 +02:00
Hadi Nategh
e0b98b7c4c Change framework user avatar to et2-avatar 2022-09-07 11:53:29 +02:00
nathan
7f94b3ae6c Et2Date: Add "Today" button 2022-09-06 11:32:25 -06:00
nathan
6b4a16357f Et2LinkAppSelect: Fix displayed icon did not change when value changed 2022-09-06 11:11:13 -06:00
nathan
365f29f498 Explicitly translate labels & statustext in nm rows 2022-09-06 09:17:12 -06:00
nathan
cc132a8d72 Revert "getting label / tooltip of images to be translated", fixed another way.
This reverts commit 06ae750b32.
2022-09-06 09:16:25 -06:00
ralf
c31b99112d * Mail: remove left (and right) margin of p and div, which can interact bad with the signature 2022-09-06 15:41:45 +02:00
Hadi Nategh
378a6f50b7 Get tree icons the same size as buttons 2022-09-06 11:55:14 +02:00
Hadi Nategh
921f299f0b Get icon buttons in same size in the nextmatch header 2022-09-06 10:44:49 +02:00
ralf
06ae750b32 getting label / tooltip of images to be translated
not sure why this is necessary, as Et2Widgets lists label and statustext as to translate ...
2022-09-06 10:41:08 +02:00
Hadi Nategh
0b4d55fd1c Fix radiobox styling 2022-09-05 14:51:12 +02:00
ralf
1ec9ef63fe fix Uncaught TypeError: Failed to execute 'getComputedStyle'
thought the image no longer changes, when selecting another one :(
2022-09-05 13:59:07 +02:00
ralf
a559e2d3da Changelog for 21.1.20220905 2022-09-05 10:59:23 +02:00
ralf
cf355d1d5c do NOT stall because DB does not know the TZ, report once per session
Happens with PHP 8.1 and older MariaDB (or MySQL) without (loaded) timezone data
Unknown or incorrect time zone: 'UTC'
2022-09-05 10:52:29 +02:00
Hadi Nategh
978d356eed Set background color for buttons used in dialogs footer 2022-09-05 10:10:11 +02:00
nathan
f6851daf9f Fix mail tree actions
Node was a jQuery object instead of DOMNode
2022-09-02 14:37:35 -06:00
Hadi Nategh
ed87a8039a Implement Spinner widget 2022-09-02 13:50:38 +02:00
nathan
daf63d9c23 Et2Select: If multiple and no value, overlap the search onto the widget 2022-09-01 11:53:19 -06:00
nathan
7fc28f9fb5 Fix "today" was not marked in flatpickr calendars 2022-09-01 10:35:23 -06:00
nathan
24daafb9ef Et2Select: If somebody set '' as an option value then '' is not a bad value and doesn't need to be fixed. 2022-09-01 09:58:08 -06:00
nathan
1bbcdbfeb7 Fix Et2SelectAccount couldn't have non-account options, so freeEntries didn't show up 2022-09-01 08:30:43 -06:00
nathan
2e319319d1 Fix general free entries did not validate with 0 validators 2022-09-01 08:29:46 -06:00
nathan
a3d2674757 Et2Select + search: Fix some bugs
- Select a searched value didn't validate due to different attribute name
- et2-searchbox inside et2-select threw an additional change event, needed to catch that
- fix_bad_value() needs different handling when you can search, otherwise it just gets cleared again
2022-08-31 13:28:20 -06:00
Hadi Nategh
2507fc99bd Fix broken attached label in description 2022-08-31 13:01:06 +02:00
Hadi Nategh
8555fa2f8f Fix description & label not being aligned in middle (happens for labels not wrapped in table) 2022-08-31 12:27:52 +02:00
Hadi Nategh
38d7604115 Prevent execution error 2022-08-31 12:24:49 +02:00
nathan
6458511d75 Et2Select: Fix some missing "emptyLabel" bugs
- If there were no select_options, and an invalid value, empty label was not shown (Infolog pricelist)
- Select Number had numeric values for options which did not match string values (Infolog completed)
2022-08-30 14:27:19 -06:00
nathan
5cfa26bd7b Fix line break after widget name broke legacy option parser 2022-08-30 13:56:13 -06:00
nathan
446b51d74a Customfields: Explicitly use description widget for readonly text fields 2022-08-30 13:28:15 -06:00
Hadi Nategh
f65020ab93 WIP Ui: Try to give same spacing for dialogHeader and dialogFooter 2022-08-30 11:57:52 +02:00
Hadi Nategh
deabd5ae53 WIP Ui: fix some rows in dialogs getting wrongly aligned in the middle 2022-08-30 09:12:31 +02:00
Hadi Nategh
6b18fa7db9 WIP Ui: adopt to the shoelace font-family and size 2022-08-30 08:54:29 +02:00
Hadi Nategh
e1a87caf6c WIP of better UI 2022-08-30 07:50:43 +02:00
nathan
d521d2aa24 Admin: Fix some errors deleting a group
- use the minified app.js
- export the JS class
- include the PHP command class explicitly so it's always found
- Make sure to send all expected parameters to ajax_delete_group
2022-08-29 14:25:39 -06:00
nathan
aee54e5f45 Fix text customfield with rows set did not result in multi-line textarea 2022-08-29 09:21:49 -06:00
Hadi Nategh
31e83ddf05 Stop tags being drawn to the max width 2022-08-29 16:47:58 +02:00
nathan
1b0c2a95a2 Fix nextmatch search 2022-08-29 08:44:09 -06:00
Hadi Nategh
feb476b8cd Add a placeholder icon when no country is selected in Et2-SelectCountry widget 2022-08-29 15:41:04 +02:00
nathan
12ef8163b4 Fix double nextmatch refresh if you search, press [Enter], then take focus out of the search 2022-08-26 13:23:36 -06:00
nathan
234b2c78b9 Et2SelectCountry: Fix limited size of search box
There was a conflict between flag style & search styles.  Now using a specific element for the current value flag instead of styling the whole slot.
2022-08-26 11:48:02 -06:00
nathan
23977d6c21 Fix "select all" long task threw an error and didn't complete
Progressbar was not found because the load event was never fired from the dialog.
2022-08-26 09:28:33 -06:00
nathan
6d38f22949 Add "Just me" as empty_label in add favorite dialog 2022-08-26 08:34:16 -06:00
Hadi Nategh
e2fbbef09b Fix tree nodes getting wrong bg color on hover 2022-08-26 11:47:18 +02:00
nathan
b136958425 Et2Select: (multiple=false) When searching and user selects a value, abort search and show all non-matching entries again 2022-08-25 15:51:15 -06:00
nathan
4d8bd89952 Et2Widget: Fix widgets could not pull objects from content to use as attributes
et2-vfs-mime for files in kanban is an example
2022-08-25 13:25:45 -06:00
nathan
080dea2378 Fix add favorites
Changed to use a proper template & dialog, now that we have et2-details widget.
2022-08-25 11:47:21 -06:00
nathan
d25a0b215e Some work on a visual test, not yet working 2022-08-25 10:19:45 -06:00