Commit Graph

2815 Commits

Author SHA1 Message Date
nathan
62bc77a4d2 Make sure egw.lang() doesn't error trying to translate option label
This un-reverts 4e5f68f97c
2023-01-25 14:24:08 -07:00
nathan
4b8b454566 Make sure values are strings, otherwise they might not match comparison
Should fix tracker list "Created by" filter losing display when you select a search result
2023-01-25 13:43:35 -07:00
ralf
6ef78c9591 Revert "Fix missing translation on read-only select"
Causes:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'toLowerCase')
    at Object.lang (egw_lang.js:73:16)
    at Et2SelectAccountReadonly._readonlyRender (Et2SelectReadonly.ts:189:59)
    at Et2SelectAccountReadonly.render (Et2SelectReadonly.ts:168:16)
    at Et2SelectAccountReadonly.update (lit-element.js:6:304)
    at Et2SelectAccountReadonly.performUpdate (reactive-element.js:6:4849)
    at Et2SelectAccountReadonly.scheduleUpdate (reactive-element.js:6:4496)
    at Et2SelectAccountReadonly._$Ej (reactive-element.js:6:4404)

This reverts commit 4e5f68f97c.
2023-01-25 09:46:22 +01:00
nathan
4e5f68f97c Fix missing translation on read-only select 2023-01-24 14:44:28 -07:00
nathan
9bf0149645 Fix selectbox positioning issue
Tracker owner would open down instead of up with fontsize = 14.  Updating to shoelace 2.0.0-beta.81 fixes it.  Going farther introduces some other issues that I don't want to get into right now
2023-01-24 13:58:38 -07:00
nathan
49d3d84f3a Completely hide disabled nm filters, as before 2023-01-24 10:25:01 -07:00
nathan
56fcfbf992 No 'All categories' empty label for mail 2023-01-24 09:26:46 -07:00
nathan
2332c2a806 Et2Tag: Make edit textbox larger 2023-01-24 08:27:52 -07:00
ralf
9fb153bbcc fix historylog in calendar not shown
caused by multi-attributes use a vbox, who's constructor unset the readonly attribute
--> setting it again hard, as all widgets in historylog are r/o and without readonly select-boxes have no detached DOM interface
2023-01-24 14:31:16 +01:00
nathan
7518278948 Add edit button to freeEntry selectbox tags 2023-01-23 17:34:37 -07:00
nathan
802a312839 Stop nextmatch from making a popup dirty if a filter changes 2023-01-19 14:40:56 -07:00
ralf
5fe8f2642a fix problem with Safari 16.2 of NOT displaying dialog contents eg. of timer dialog 2023-01-19 15:23:16 -06:00
nathan
86917eff65 Fix file settings error "'0' is NOT allowed ('not found')!" for gid.
It did not have a '0' => 'root' option, which is what we were using for the value.
2023-01-19 09:21:03 -07:00
nathan
80fbd3cc26 Fix placeholder widget
IDs on et2-boxes caused unwanted namespace, Et2Listbox couldn't find its ID before fully initializing
2023-01-19 08:44:52 -07:00
nathan
3f5cb42c96 Fix vfsUpload didn't open mail files 2023-01-18 13:07:04 -07:00
Hadi Nategh
03123ee729 Fix wrong label set for dark mode switch 2023-01-18 12:15:26 +01:00
nathan
3164cb6dd0 Make sure we get the right popup if multiple nextmatches use the same popup ID 2023-01-17 15:35:28 -07:00
nathan
6774f2e9d4 Remove another class that could be hiding popup contents 2023-01-17 14:30:28 -07:00
nathan
2ab7079f13 Et2LinkString: Can now fetch its own link data, given application & entryId
Includes some fixes for only_app filter
2023-01-17 14:03:28 -07:00
nathan
38b507dcd1 Et2Date: Stop required validation showing on initial load even with a value 2023-01-17 10:52:02 -07:00
nathan
a5929388fc Et2VfsMime: Add value getter
Fixes tracker comments with more than one image would only show the last
2023-01-17 08:37:24 -07:00
nathan
d87e0c7f38 Fix missing default button images 2023-01-16 16:15:57 -07:00
nathan
19c02fc91c Et2InputWidget: Do not try to validate readonly widgets, user can't change the value to fix it 2023-01-16 08:55:31 -07:00
Hadi Nategh
10c646a367 Make sure the sort and shadowRoot are there before using them, avoiding execution error, since getValue it could be called in earlier stage eg: a699117b1b 2023-01-16 12:55:45 +01:00
nathan
374ba994a4 Customfield validation fixes
- customfield did not pass required setting on to widgets
- link entry did not support required
2023-01-13 11:28:02 -07:00
nathan
1a969c4cfc Et2Date: Fix validation message display
Required validation was incorrectly displayed / not hidden
2023-01-13 08:40:21 -07:00
nathan
461e83df28 Remove all validation messages on focus, not just manual / server-side messages.
Server side ones are still re-added on blur, client-side messages are re-run.
2023-01-12 09:17:29 -07:00
ralf
4e1b31bb37 also legacy-load old phpgwapi JS code like tabs using in KB 2023-01-12 08:43:17 -06:00
nathan
4f7b54c6bb Fix some more select attribute / legacy options issues 2023-01-11 15:49:56 -07:00
nathan
a699117b1b Fix hiding server-side messages for selectboxes
Messages were not properly hidden & displayed, and setting handleFocus & handleBlur accidentally overwrote them in Shoelace widgets
2023-01-11 11:11:02 -07:00
nathan
1163f9e31d Hide server-side validation messages while widget has focus. If the value did not change, put messages back 2023-01-09 16:02:59 -07:00
nathan
ffb26cb2f1 Change tree icon size from 20px to 16px
Can be overridden in CSS now
2023-01-09 14:36:44 -07:00
nathan
56f84f2fdd Fix swapped open / closed icons in tree 2023-01-09 13:19:40 -07:00
nathan
ba608fddc7 Et2Split: Fix incorrect / frozen sizing of split in Firefox
If user dragged very quickly & released the mouse button before the resize was complete, we would wind up with incorrect size
2023-01-06 11:07:50 -07:00
nathan
323115b041 Replace font size accidentally removed in 40278c8827 2023-01-06 09:11:54 -07:00
nathan
39ab880188 Don't die if CustomFilterHeader is for a component that isn't a webcomponent, just error & use a select 2023-01-05 16:36:03 -07:00
nathan
c403edc49a Fix incorrect suggested password length 2023-01-05 15:35:04 -07:00
nathan
f8a8a290ce Tests for switch widget 2023-01-05 14:06:54 -07:00
nathan
3ecd9c222b Fix switch widget did not validate value server-side 2023-01-05 14:06:39 -07:00
nathan
9a190321c1 Et2Button: Fix class mixup that broke buttons 2023-01-05 09:00:02 -07:00
nathan
ca5d80264c Less errors in date tests, still not passing 2023-01-05 08:38:56 -07:00
nathan
37dd18894f Get tests for Colorpicker passing again 2023-01-04 15:33:48 -07:00
nathan
acd44a1e0e Get tests for Button passing again 2023-01-04 15:03:43 -07:00
nathan
40278c8827 Get our WebComponent tests running again
Made a lot of "failed to construct htmlelement" errors go away, avoid a bunch of egwIsMobile is undefined errors
2023-01-04 12:01:09 -07:00
nathan
ac1d8b6be8 Fix TypeError: Cannot read properties of null (reading 'replace')
Fixes unable to edit tracker in mobile view.
2023-01-02 16:20:50 -07:00
nathan
b8c3a97138 Et2Tabs: fix keyboard navigation 2022-12-22 14:51:48 -07:00
nathan
b0bedc8467 Accessability improvements
- Toolbar buttons get label, but it is visually hidden
- Add label to calendar Add button
2022-12-22 14:14:45 -07:00
nathan
c617dfe080 Fix placeholder sub-groups were not showing 2022-12-21 12:28:59 -07:00
nathan
098fe647dc Start on converting date range to webcomponent 2022-12-20 14:05:20 -07:00
nathan
28678c48f4 remove debug 2022-12-19 13:08:21 -07:00
nathan
7d94692dfd Fix some missing account names
- egw().accounts() were not cleaned
- accounts not in normal cache did not call requestUpdate() properly
2022-12-19 12:01:29 -07:00
nathan
ac97af35cb Lets try creating options directly when we get them, rather than going through update first
Timing was not getting menu items created soon enough, resulting in IDs instead of names in the options
2022-12-16 11:48:12 -07:00
nathan
9ce0520e5c Allow actually disabled inputs 2022-12-16 10:40:58 -07:00
nathan
272b63d32e Explicitly define autofocus as reflected so it works in Firefox too 2022-12-15 13:18:16 -07:00
nathan
a9fe524123 Et2Select: Fix value got wrecked by fix_bad_value() when there are option groups 2022-12-15 11:31:56 -07:00
nathan
e756962f86 Change egw.accounts() to always return a Promise 2022-12-15 10:22:19 -07:00
nathan
2ed0479380 Add nm action dialogs into application tab, not document body 2022-12-14 16:10:50 -07:00
nathan
3b5f64a4c3 Implement option groups 2022-12-14 14:32:20 -07:00
nathan
a832c12dbc Fix DnD to link file to entry 2022-12-14 11:56:27 -07:00
nathan
54498a005c Et2Dialog: Second try waiting on template load
Now creating the template promise immediately on setting template name and using a resolver function to resolve after template is loaded
2022-12-14 10:39:15 -07:00
nathan
6c4c42bcde Translation of "on vacation" from Birgit 2022-12-12 15:09:57 -07:00
nathan
27573f6d83 Et2Dialog: Try waiting until after update is complete to avoid an error loading the template in Safari 2022-12-12 14:43:47 -07:00
nathan
65a7abeca2 A little more space for details dropdown 2022-12-12 14:26:54 -07:00
nathan
5acc8c55c8 Et2SelectEmail: Fix fullEmail did not show full email 2022-12-12 14:07:08 -07:00
nathan
34172704dc Fix SelectAccount didn't always get values into options correctly 2022-12-12 13:10:53 -07:00
nathan
9acda4b390 Link fixes
- Fix file that was linked then removed before first save was still linked on save
- Use events for better decoupling between Et2LinkTo & Et2LinkList
2022-12-12 10:32:08 -07:00
nathan
0f37d2f437 Fix sometimes missing accounts for SelectAccount widgets 2022-12-09 13:16:44 -07:00
nathan
6177ca0536 SearchMixin: Filter selected remote correctly for single selects too 2022-12-09 13:14:57 -07:00
nathan
5f44c51d89 Et2Checkbox: Fix internal positioning was causing entire page to overflow 2022-12-09 10:55:19 -07:00
nathan
8ed40c8c0e Et2SelectThumbnail: Fix current value(s) did not display 2022-12-09 09:03:43 -07:00
nathan
dd39305443 Fix VFS upload couldn't show newly uploaded files 2022-12-08 15:01:25 -07:00
nathan
4b4d6fe184 Stop scrolling new tag into view, it causes calendar sidemenu to get stuck 2022-12-08 14:47:02 -07:00
nathan
ce64ddf9e0 Fix doubled tags if widget gets select_options after a remote option is selected 2022-12-08 14:28:05 -07:00
ralf
26d4082cda fix not working buttons in timer dialog 2022-12-08 20:13:32 +01:00
nathan
691928a54c Fix attachments not displayed in tracker comments 2022-12-08 11:39:00 -07:00
nathan
be5125509e SearchMixin: Fix selecting multiple remote values only showed the last 2022-12-08 10:24:49 -07:00
nathan
d7f8f7d997 Fix editing link remark did not load current value 2022-12-07 15:51:50 -07:00
nathan
c26732a913 Some more fixes for historylog widget
- Fix options in proper format could be interpreted as sub-widgets
- Fix numeric values
2022-12-07 15:04:22 -07:00
nathan
12151139ff Et2Dialog: Better non-modal handling, now with less internal conflicts with SlDialog 2022-12-07 13:45:38 -07:00
nathan
32248e67ee Et2Dialog: Better non-modal styling 2022-12-07 11:30:14 -07:00
nathan
4b6357dd90 Et2Dialog nonmodal WIP
Non-modal dialogs don't cover header with app tabs.
TODO: The dialog needs to be added to the app content div instead of the body
2022-12-07 09:13:46 -07:00
nathan
fb40aedf89 SearchMixin: Use parent set select_otions, no need to duplicate 2022-12-06 11:59:51 -07:00
nathan
daa999d586 Et2LinkList: Fix context menu actions 2022-12-06 10:55:20 -07:00
nathan
25f64d0064 Fix error on some bad options
Would sometimes stop historylog from loading
2022-12-06 10:05:47 -07:00
nathan
57993741cb Et2Dialog: Don't close dialog for buttons that are not in the footer 2022-12-06 09:44:56 -07:00
nathan
3971abc54b Fix some select options were not being cleaned
Integer values provided from server were not being converted to strings, breaking value handling & matching
2022-12-06 09:13:04 -07:00
nathan
2188791540 Et2LinkList: Fix context menu "Save As" gave error
Cannot read properties of undefined (reading 'dispatchEvent')
2022-12-05 17:05:10 -07:00
nathan
fa2375b1a6 SearchMixin: Fix selected remote options got lost if adding a freeEntry 2022-12-05 13:56:31 -07:00
nathan
e875b9ddf4 Use same background color for primary buttons 2022-12-05 10:54:05 -07:00
nathan
b2b3caaa64 Fix searchbox triggered change an extra time after pressing Enter key 2022-12-05 10:31:15 -07:00
nathan
2b02d4e9ab Fix listbox sometimes lost value 2022-12-05 10:11:17 -07:00
nathan
7ba5730251 Change properties to camelCase 2022-12-05 09:42:55 -07:00
nathan
4399e276eb Remove debug 2022-12-05 09:39:08 -07:00
nathan
3a1c415ce4 Styling for buttons on dialog 2022-12-02 11:23:09 -07:00
nathan
2f81a55607 Et2Searchbox: Consume enter keypress in search to avoid triggering anything else. Just start the search. 2022-12-02 09:54:35 -07:00
nathan
8717033009 Fix JS errors in placeholder dialog 2022-12-02 09:39:25 -07:00
nathan
72626b0dc2 Et2Dialog: Fix width property 2022-12-02 09:37:22 -07:00
ralf
e72e628c81 give focus back to previous active element instead of focusing on first input 2022-12-02 14:42:36 +01:00
nathan
6eebabe472 SearchMixin: Fix tag edit
Double clicking just cleared the input, edit was immediately stopped due to search blur
2022-12-01 14:54:34 -07:00
nathan
404a29b985 SearchMixin: If user enters a valid free entry then changes focus without pressing Tab or Enter key, accept the free entry 2022-12-01 14:15:40 -07:00
nathan
c81ff8b444 Fix disabled buttons had different styling than normal buttons 2022-12-01 13:03:39 -07:00
nathan
dc5e0b528e Dialog work
Style changes
2022-12-01 13:02:40 -07:00
nathan
e2fc779207 Dialog work
Get tracker "Multiple changes" working
2022-12-01 11:38:02 -07:00
nathan
634e00f948 Dialog work
Get calendar quick add working again
2022-12-01 11:20:58 -07:00
nathan
83ab58329e Dialog work
- Add destroy() to remove dialog

Fixes admin ACL dialog
2022-12-01 10:24:17 -07:00
nathan
390fbf3608 Dialog work
- Switch from LionDialog to SlDialog as base
- First input should get focus
- First button gets set as primary (if no default set), Enter key will act as a click on it
- Escape key closes dialog
2022-11-30 15:59:25 -07:00
nathan
faff3834bc Use same font size for help text as for labels 2022-11-25 11:53:23 -07:00
nathan
ea845b8c4d Et2Textbox: Translate helpText 2022-11-25 11:38:36 -07:00
nathan
a79538ffbc Et2LinkList: Don't show context menu or delete for readonly lists 2022-11-25 11:19:13 -07:00
nathan
6238302901 Let new boxes repeat as well as legacy boxes 2022-11-25 11:18:44 -07:00
nathan
2e61c3a23e Et2Box: Implement elign=center 2022-11-25 11:18:12 -07:00
nathan
be82f32b68 When nm is on a tab, need to resize the nm when the tab is shown to get proper sizing 2022-11-24 14:20:45 -07:00
nathan
9f26cbf1e5 Use method to set data 2022-11-24 11:50:36 -07:00
nathan
5c3d35aa05 Fix missing SVG icons for some images
They weren't missing, just 0x0px
2022-11-23 14:35:36 -07:00
nathan
b31ce0922d Implement data widget property
Fixes missing priority colors in Kanban
2022-11-23 10:30:22 -07:00
nathan
6d41c9c30b Et2SelectAccount: Avoid error if option does not have an image 2022-11-21 09:16:38 -07:00
nathan
1d540aa74c Fix additional options to a static list were not properly added if they were in correct format with value & label 2022-11-21 09:14:27 -07:00
nathan
fd8f688e8b Avoid error if input node isn't created yet 2022-11-18 13:59:20 -07:00
nathan
681d51cb14 Fix ExposeMixin "this.activeIndicator.removeClass is not a function"
If a file is allowed by MIME_REGEX, it needs to be included in list or counts will be off, causing error when closing
2022-11-15 14:27:03 -07:00
nathan
6a5d189489 Better fix for Et2SelectState not getting country set 2022-11-14 14:41:08 -07:00
nathan
ed2eb30b32 Fix widgets don't appear disabled when they are 2022-11-14 11:22:56 -07:00
nathan
ae961f208d Fix a few js errors in expose 2022-11-11 12:53:33 -07:00
nathan
e0617394fb Make weekend toggle better responsive to content size preference 2022-11-11 11:32:06 -07:00
nathan
bd584e468c Check if websocket is connected as part of pushAvailable() check 2022-11-11 08:46:34 -07:00
nathan
47a48b386f Et2Select: Fix change event got fired too early
Don't need to block the event if we didn't actually change the value.  This fixes changing to common preferences
2022-11-09 15:34:28 -07:00
nathan
32bd2a1084 SearchMixin: Make sure dropdown doesn't cover bottom border 2022-11-09 09:30:53 -07:00
ralf
5f6ab54c83 fix undefined response error caused by empty response body 2022-11-09 11:03:54 +01:00
nathan
4dffd24feb Et2Select: Fix change event got fired too early
Second attempt.  If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called.  Now making sure that event does not get fired.
2022-11-08 11:04:03 -07:00
ralf
8b0e5867cb fix JS error on displaying validation message, probably when tab is not yet loaded 2022-11-08 12:51:41 +01:00
nathan
104680c477 Fix hidden nm with no initial rows were requesting data too early 2022-11-07 14:51:42 -07:00
ralf
5302675aac new method egw.pushAvailable() : bool to check availability of push-server on client-side 2022-11-07 21:31:23 +01:00
nathan
be16565cc4 Filemanager can now update sub-grids 2022-11-07 11:51:30 -07:00
nathan
78333613fa Et2Select: Fix change event got fired too early
If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called
2022-11-07 09:57:00 -07:00
Hadi Nategh
8b83ed85d3 Fix egw messages in popup are wrongly positioned 2022-11-07 16:44:00 +01:00
nathan
d35eacb8a2 Fix gap between label & control, better solution for date-duration 2022-11-04 09:41:45 -06:00
nathan
ee52509fca Et2Checkbox: Change vertical align, it wasn't lining up nicely in calendar edit 2022-11-04 08:42:57 -06:00
nathan
74f7f4dcb5 Et2SelectReadonly: Allow additional supplied options, but fix bug where they overwrote account options 2022-11-02 14:03:12 -06:00
nathan
87aba966c2 Et2LinkString: Fix links not shown immediately after 'Apply', only after reload 2022-11-02 11:59:10 -06:00
nathan
127ccdedbb Et2Dialog: Fix incorrect button adoption search 2022-11-02 08:36:44 -06:00
ralf
0ec8636a7b do NOT submit dialog, if it has no etemplate_exec_id, it only gives and error on server-side 2022-11-02 13:51:17 +01:00
Hadi Nategh
179e12ac68 Make sure value_id is there before using it (caused a side effect on calendar entry can not be saved anymore) 2022-11-02 12:27:49 +01:00
nathan
953166b161 Fix problems with links from mail
- unsaved links were not properly displayed
- unsaved links could not be removed
- calendar preserved original links, so even if you removed one it came back
2022-11-01 15:38:58 -06:00
nathan
6764ef979b Et2Date: Use regular inputs for mobile 2022-11-01 10:34:52 -06:00
nathan
12926c89e3 Et2DateDuration: Force label not to wrap 2022-10-31 13:58:26 -06:00
nathan
e5a88c35f5 Fix date duration label always showed above the input, never to the left 2022-10-28 11:48:42 -06:00
nathan
2659a8ab63 Filemanager: Add copy to clipboard button to share link dialog 2022-10-28 10:05:03 -06:00
ralf
38e7a977d1 when time get overwritten/updated, we need to set last time, to avoid error that time can not be set before last action 2022-10-25 20:16:23 +02:00
nathan
f6883c33fd Add gap inside link widgets between each component 2022-10-25 11:38:48 -06:00
nathan
727db2aab5 Fix context menu actions that use nm_action gave "Uncaught nm_action is not a function!" 2022-10-24 10:20:56 -06:00
nathan
24fb01d190 Filemanager: Add push support 2022-10-24 09:58:11 -06:00