extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-22 23:00:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

disabling immediate direct call to loadingFinished() for selected tab seems to have no recognisable impact

Browse Source 
and some widgets, eg. color-picker have problems with calling doLoadingFinished twice
This commit is contained in:
Ralf Becker 2014-10-13 09:07:23 +00:00
parent 8298fdefcf
commit 026347ba2f
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
etemplate/js/et2_widget_tabs.js
View File

@ -236,12 +236,16 @@ var et2_tabbox = et2_valueWidget.extend([et2_IInput],
// We can do this and not wind up with 2 because child is a template, // We can do this and not wind up with 2 because child is a template,
// which has special handling // which has special handling
this._children[0].loadingFinished(promises); // disabling immediate direct call for selected tab seems to have no recognisable impact and
// some widgets, eg. color-picker have problems with calling doLoadingFinished twice
// (color input gets re-rendered second time after hitting [Apply], if color-picker is in a tab)
//this._children[0].loadingFinished(promises);
// Defer parsing & loading of other tabs until later // Defer parsing & loading of other tabs until later
window.setTimeout(function() { window.setTimeout(function() {
for (var i = 0; i < tabs.tabData.length; i++) for (var i = 0; i < tabs.tabData.length; i++)
{ {
if (i == tabs.selected_index) continue;
tabs._loadTab(i,promises); tabs._loadTab(i,promises);
} }
jQuery.when.apply(jQuery,promises).then(function() { jQuery.when.apply(jQuery,promises).then(function() {
@ -343,7 +347,7 @@ var et2_tabbox = et2_valueWidget.extend([et2_IInput],
/** /**
* Gets the index of the currently active tab * Gets the index of the currently active tab
* *
* @returns {number} * @returns {number}
*/ */
get_active_tab: function() { get_active_tab: function() {
@ -352,7 +356,7 @@ var et2_tabbox = et2_valueWidget.extend([et2_IInput],
/** /**
* Sets the currently active tab by index * Sets the currently active tab by index
* *
* @param {number} _idx * @param {number} _idx
*/ */
setActiveTab: function(_idx) { setActiveTab: function(_idx) {