fix Scrutinizer "bugs"

This commit is contained in:
Ralf Becker 2016-07-02 11:47:25 +02:00
parent 07ddc1a054
commit 03e3ae3c58

View File

@ -1030,7 +1030,8 @@ class Ldap
* Query the members of a group * Query the members of a group
* *
* @param int $_gid * @param int $_gid
* @return array with uidnumber => uid pairs * @return array|boolean array with uidnumber => uid pairs,
* false if $_git is not nummeric and can't be resolved to a nummeric gid
*/ */
function members($_gid) function members($_gid)
{ {
@ -1086,7 +1087,7 @@ class Ldap
// adding new memberships // adding new memberships
foreach($old_memberships ? array_diff($groups,$old_memberships) : $groups as $gid) foreach($old_memberships ? array_diff($groups,$old_memberships) : $groups as $gid)
{ {
$members = $this->members($gid); if (!($members = $this->members($gid))) $members = array();
$members[$account_id] = $this->id2name($account_id); $members[$account_id] = $this->id2name($account_id);
$this->set_members($members,$gid); $this->set_members($members,$gid);
} }