From 0438456ad37e08d9babb633c921780560de3a09c Mon Sep 17 00:00:00 2001
From: Nathan Gray <nathangray.bsc@gmail.com>
Date: Tue, 29 Sep 2015 16:21:05 +0000
Subject: [PATCH] Prevent apps from modifying favorites by reference.

Fixes projectmanager favorites stop working
---
 phpgwapi/js/jsapi/app_base.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/phpgwapi/js/jsapi/app_base.js b/phpgwapi/js/jsapi/app_base.js
index 36f874ba55..637e5eca84 100644
--- a/phpgwapi/js/jsapi/app_base.js
+++ b/phpgwapi/js/jsapi/app_base.js
@@ -390,7 +390,8 @@ var AppJS = Class.extend(
 					var pref = egw.preference('favorite_' + this.dataset.id, self.appname);
 					if(pref)
 					{
-						state = pref;
+						// Extend, to prevent changing the preference by reference
+						jQuery.extend(true, state, pref);
 					}
 					if(this.dataset.id != 'add')
 					{