Fix some issues from the shoelace version bump

- SlSelect.getItemLabel() not there anymore
- SlSelect.menuItems is now a real list, and fails when parent tries to write to it
- Tabs didn't hide properly when not active, giving a scrollbar
This commit is contained in:
nathan 2022-08-04 13:47:16 -06:00
parent 6b1a477de8
commit 098c2ab3f0
2 changed files with 4 additions and 6 deletions

View File

@ -406,7 +406,7 @@ export class Et2Select extends Et2WithSearchMixin(Et2WidgetWithSelect)
{
const tag = <Et2Tag>document.createElement(this.tagTag);
tag.value = item.value;
tag.textContent = this.getItemLabel(item);
tag.textContent = item.getTextLabel().trim();
tag.class = item.classList.value + " search_tag";
if(this.size)
{
@ -453,11 +453,6 @@ export class Et2Select extends Et2WithSearchMixin(Et2WidgetWithSelect)
return "";
}
public get menuItems() : HTMLElement[]
{
return [...this.querySelectorAll<SlMenuItem>(this.optionTag)];
}
/**
* Override parent to always call validate(), as our simple implementation needs to validate on clear as well.
*

View File

@ -42,6 +42,9 @@ export class Et2Tabs extends Et2Widget(SlTabGroup)
::slotted(et2-tab-panel) {
flex: 1 1 auto;
}
::slotted(et2-tab-panel:not([active])) {
display: none;
}
`
];
}