extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-03 12:39:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug in egwActionObject.selectAll function which caused the internal 'selectedChildren' array to be a reference to the children array and resulted in the children array being destroyed.

Browse Source
This commit is contained in:
Andreas Stöckel 2011-03-23 14:36:25 +00:00
parent 3ea7ca54b8
commit 0b2168e924
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
phpgwapi/js/egw_action/egw_action.js
View File

@ -1080,7 +1080,14 @@ egwActionObject.prototype.setAllSelected = function(_selected, _informParent)
} }
// Copy the selected children list // Copy the selected children list
this.selectedChildren = _selected ? this.children : []; this.selectedChildren = [];
if (_selected)
{
for (var i = 0; i < this.children.length; i++)
{
this.selectedChildren.push(this.children[i]);
}
}
} }

8
phpgwapi/js/egw_action/egw_action_popup.js
View File

@ -309,6 +309,8 @@ function egwPopupActionImplementation()
_links[k].actionObj.appendToTree(tree); _links[k].actionObj.appendToTree(tree);
} }
// We need the dummy object container in order to pass the array by
// reference
var groups = { var groups = {
"groups": [] "groups": []
}; };
@ -321,12 +323,8 @@ function egwPopupActionImplementation()
var menu = new egwMenu(); var menu = new egwMenu();
// We needed the dummy object container in order to pass the array as
// reference - this is not needed anymore
groups = groups.groups;
// Build the menu layers // Build the menu layers
this._buildMenuLayer(menu, groups, _selected, true); this._buildMenuLayer(menu, groups.groups, _selected, true);
return menu; return menu;
} }