* Addressbook/PostgreSQL: fixed SQL error when checking "use whole query"

This commit is contained in:
Ralf Becker 2011-04-15 06:50:48 +00:00
parent 4b7a6ed291
commit 2727fc4abc

View File

@ -441,7 +441,7 @@ class addressbook_sql extends so_sql
break;
}
// postgres requires that expressions in order by appear in the columns of a distinct select
if ($this->db->Type != 'mysql' && preg_match_all("/([a-zA-Z_.]+) *(<> *''|IS NULL|IS NOT NULL)/u",$order_by,$all_matches,PREG_SET_ORDER))
if ($this->db->Type != 'mysql' && preg_match_all("/([a-zA-Z_.]+) *(<> *''|IS NULL|IS NOT NULL)? *(ASC|DESC)?(,|$)/ui",$order_by,$all_matches,PREG_SET_ORDER))
{
if (!is_array($extra_cols)) $extra_cols = $extra_cols ? explode(',',$extra_cols) : array();
foreach($all_matches as $matches)
@ -451,8 +451,7 @@ class addressbook_sql extends so_sql
{
$table = ($matches[1] == $this->extra_value ? $this->extra_table : $this->table_name).'.';
}
$extra_cols[] = $table.$matches[1];
$extra_cols[] = $table.$matches[0];
$extra_cols[] = $table.$matches[1].' '.$matches[2];
//_debug_array($matches);
if (!empty($order_by) && $table) // postgres requires explizit order by
{