mirror of
https://github.com/EGroupware/egroupware.git
synced 2025-01-03 04:29:28 +01:00
Fix validation messages after Shoelace update
- some messages (textbox) were out of position - Selectboxes did not show validation message - Selectbox considered false a valid value for required, even if that wasn't an option
This commit is contained in:
parent
3cf4cbab9a
commit
2e2c3fb0b6
@ -7,6 +7,9 @@ import {LionValidationFeedback, Validator} from "@lion/form-core";
|
|||||||
import {et2_csvSplit} from "../et2_core_common";
|
import {et2_csvSplit} from "../et2_core_common";
|
||||||
import {dedupeMixin} from "@lion/core";
|
import {dedupeMixin} from "@lion/core";
|
||||||
|
|
||||||
|
// LionValidationFeedback needs to be registered manually
|
||||||
|
window.customElements.define('lion-validation-feedback', LionValidationFeedback);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This mixin will allow any LitElement to become an Et2InputWidget
|
* This mixin will allow any LitElement to become an Et2InputWidget
|
||||||
*
|
*
|
||||||
@ -87,7 +90,7 @@ const Et2InputWidgetMixin = <T extends Constructor<LitElement>>(superclass : T)
|
|||||||
width: 100%;
|
width: 100%;
|
||||||
}
|
}
|
||||||
|
|
||||||
.form-field__feedback {
|
.form-control__help-text {
|
||||||
position: relative;
|
position: relative;
|
||||||
}
|
}
|
||||||
`
|
`
|
||||||
|
@ -327,7 +327,7 @@ export class Et2Select extends Et2WithSearchMixin(Et2WidgetWithSelect)
|
|||||||
}
|
}
|
||||||
|
|
||||||
// emptyLabel is fine
|
// emptyLabel is fine
|
||||||
if(!(this.value) && this.value !== '0' && (this.emptyLabel || this.placeholder))
|
if((this.value == '' || this.value == []) && (this.emptyLabel || this.placeholder))
|
||||||
{
|
{
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@ -856,6 +856,9 @@ export class Et2Select extends Et2WithSearchMixin(Et2WidgetWithSelect)
|
|||||||
${this._optionsTemplate()}
|
${this._optionsTemplate()}
|
||||||
${this._extraTemplate()}
|
${this._extraTemplate()}
|
||||||
<slot></slot>
|
<slot></slot>
|
||||||
|
<div slot="help-text">
|
||||||
|
<slot name="feedback"></slot>
|
||||||
|
</div>
|
||||||
</sl-select>
|
</sl-select>
|
||||||
`;
|
`;
|
||||||
}
|
}
|
||||||
|
@ -2130,6 +2130,8 @@ div.message.floating, lion-validation-feedback[type] {
|
|||||||
lion-validation-feedback[type] {
|
lion-validation-feedback[type] {
|
||||||
top: initial;
|
top: initial;
|
||||||
margin-top: calc(-0.2 * var(--sl-input-height-medium));
|
margin-top: calc(-0.2 * var(--sl-input-height-medium));
|
||||||
|
width: fit-content;
|
||||||
|
white-space: nowrap;
|
||||||
}
|
}
|
||||||
|
|
||||||
.message.validation_error, lion-validation-feedback[type="error"] {
|
.message.validation_error, lion-validation-feedback[type="error"] {
|
||||||
|
Loading…
Reference in New Issue
Block a user