extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-03 04:29:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

read memberships in a single SQL query with a JOIN

Browse Source
This commit is contained in:
ralf 2022-11-04 17:49:16 +01:00
parent d35eacb8a2
commit 37c0091e3d
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
api/src/Accounts/Sql.php
View File

@ -49,6 +49,10 @@ class Sql
*/ */
const TABLE = 'egw_accounts'; const TABLE = 'egw_accounts';
var $table = self::TABLE; var $table = self::TABLE;
/**
* Location for group-memberships in ACL table
*/
const ACL_GROUP_LOCATION = 'phpgw_group';
/** /**
* table name for the contacts * table name for the contacts
* *
@ -316,22 +320,24 @@ class Sql
} }
/** /**
* Get all memberships of an account $accountid / groups the account is a member off * Get all memberships of an account $account_id / groups the account is a member off
* *
* @param int $account_id numeric account-id * @param int $account_id numeric account-id
* @return array/boolean array with account_id => account_lid pairs or false if account not found * @return array|boolean array with account_id => account_lid pairs or false if account not found
*/ */
function memberships($account_id) function memberships($account_id)
{ {
if (!(int)$account_id) return false; if (!(int)$account_id) return false;
$memberships = array(); $memberships = array();
if(($gids = $GLOBALS['egw']->acl->get_location_list_for_id('phpgw_group', 1, $account_id))) foreach($this->db->select(Api\Acl::TABLE, 'account_id,account_lid',
[
'acl_account' => $account_id,
'acl_appname' => self::ACL_GROUP_LOCATION
], __LINE__, __FILE__, false, 'ORDER BY account_lid', false, 0,
'JOIN '.self::TABLE.' ON ABS('.$this->db->to_int('acl_location').')=account_id') as $row)
{ {
foreach($gids as $gid) $memberships['-'.$row['account_id']] = $row['account_lid'];
{
$memberships[(string) $gid] = $this->id2name($gid);
}
} }
return $memberships; return $memberships;
} }
@ -348,11 +354,11 @@ class Sql
$acl = new Api\Acl($account_id); $acl = new Api\Acl($account_id);
$acl->read_repository(); $acl->read_repository();
$acl->delete('phpgw_group',false); $acl->delete(self::ACL_GROUP_LOCATION,false);
foreach($groups as $group) foreach($groups as $group)
{ {
$acl->add('phpgw_group',$group,1); $acl->add(self::ACL_GROUP_LOCATION,$group,1);
} }
$acl->save_repository(); $acl->save_repository();
} }
@ -360,7 +366,7 @@ class Sql
/** /**
* Get all members of the group $accountid * Get all members of the group $accountid
* *
* @param int/string $account_id numeric account-id * @param int|string $account_id numeric account-id
* @return array with account_id => account_lid pairs * @return array with account_id => account_lid pairs
*/ */
function members($account_id) function members($account_id)
@ -370,9 +376,9 @@ class Sql
$members = array(); $members = array();
foreach($this->db->select($this->table, 'account_id,account_lid', foreach($this->db->select($this->table, 'account_id,account_lid',
$this->db->expression(Api\Acl::TABLE, array( $this->db->expression(Api\Acl::TABLE, array(
'acl_appname' => 'phpgw_group', 'acl_appname' => self::ACL_GROUP_LOCATION,
'acl_location' => $account_id, 'acl_location' => $account_id,
)), __LINE__, __FILE__, false, '', false, 0, )), __LINE__, __FILE__, false, 'ORDER BY account_lid', false, 0,
'JOIN '.Api\Acl::TABLE.' ON account_id=acl_account' 'JOIN '.Api\Acl::TABLE.' ON account_id=acl_account'
) as $row) ) as $row)
{ {
@ -389,13 +395,13 @@ class Sql
*/ */
function set_members($members,$gid) function set_members($members,$gid)
{ {
$GLOBALS['egw']->acl->delete_repository('phpgw_group',$gid,false); $GLOBALS['egw']->acl->delete_repository(self::ACL_GROUP_LOCATION,$gid,false);
if (is_array($members)) if (is_array($members))
{ {
foreach($members as $id) foreach($members as $id)
{ {
$GLOBALS['egw']->acl->add_repository('phpgw_group',$gid,$id,1); $GLOBALS['egw']->acl->add_repository(self::ACL_GROUP_LOCATION,$gid,$id,1);
} }
} }
} }