From 3ba69d542dc7f748f147c720ec4c5f8f588ecac3 Mon Sep 17 00:00:00 2001
From: nathan <nathangray.bsc+github@gmail.com>
Date: Mon, 27 May 2024 10:49:06 -0600
Subject: [PATCH] Framework WIP - Get admin tree loading in side - Popups
 working

---
 admin/js/app.ts                   |  9 +++-
 admin/templates/default/index.xet |  2 +-
 kdots/js/EgwFramework.ts          | 79 ++++++++++++++++++++++++++++---
 kdots/js/EgwFrameworkApp.ts       |  9 +++-
 4 files changed, 89 insertions(+), 10 deletions(-)

diff --git a/admin/js/app.ts b/admin/js/app.ts
index 484c9ea54f..a949957bc6 100644
--- a/admin/js/app.ts
+++ b/admin/js/app.ts
@@ -423,7 +423,14 @@ class AdminApp extends EgwApp
 		if(!_data || _data.type != undefined) return;
 
 		// Insert the content, etemplate will load into it
-		jQuery(this.ajax_target.getDOMNode()).append(typeof _data === 'string' ? _data : _data[0]);
+		if(typeof _data === "string" || typeof _data[0] !== "undefined")
+		{
+			jQuery(this.ajax_target.getDOMNode()).append(typeof _data === 'string' ? _data : _data[0]);
+		}
+		else if(typeof _data.DOMNodeID == "string")
+		{
+			this.ajax_target.setAttribute("id", _data.DOMNodeID);
+		}
 	}
 
 	/**
diff --git a/admin/templates/default/index.xet b/admin/templates/default/index.xet
index bcebf05698..45eef7a5a8 100644
--- a/admin/templates/default/index.xet
+++ b/admin/templates/default/index.xet
@@ -83,7 +83,7 @@
 		</grid>
 	</template>
 	<template id="admin.index" template="" lang="" group="0" version="1.9.001">
-		<tree autoloading="admin_ui::ajax_tree" id="tree" onclick="app.admin.run" parent_node="admin_tree_target" std_images="bullet"/>
+        <tree slot="left" autoloading="admin_ui::ajax_tree" id="tree" onclick="app.admin.run" parent_node="admin_tree_target" std_images="bullet"/>
 		<nextmatch id="nm" template="admin.index.rows" header_left="admin.index.add"/>
 		<nextmatch id="groups" template="admin.index.group" class="hide"/>
 		<iframe frameborder="1" height="100%" id="iframe" scrolling="auto" width="100%" disabled="true"/>
diff --git a/kdots/js/EgwFramework.ts b/kdots/js/EgwFramework.ts
index 7f4820c3b3..5d704a0bcb 100644
--- a/kdots/js/EgwFramework.ts
+++ b/kdots/js/EgwFramework.ts
@@ -109,7 +109,7 @@ export class EgwFramework extends LitElement
 		if(this.egw.window && this.egw.window.opener == null && !this.egw.window.framework)
 		{
 			// This works, but stops a lot else from working
-			//this.egw.window.framework = this;
+			this.egw.window.framework = this;
 		}
 		if(this.egw.window?.framework && this.egw.window?.framework !== this)
 		{
@@ -153,10 +153,16 @@ export class EgwFramework extends LitElement
 			(menuaction ? '.' + menuaction[1] : '');
 	};
 
+	public getApplicationByName(appName)
+	{
+		return this.querySelector(`egw-app[name="${appName}"]`);
+	}
+
 	/**
 	 * Load an application into the framework
 	 *
-	 * Loading is done by name, and we look up everything we need in the applicationList
+	 * Loading is done by name, and we look up everything we need in the applicationList.
+	 * If already loaded, this just returns the existing EgwFrameworkApp, optionally activated & with new URL loaded.
 	 *
 	 * @param {string} appname
 	 * @param {boolean} active
@@ -181,8 +187,8 @@ export class EgwFramework extends LitElement
 
 		const app = this.applicationList.find(a => a.name == appname);
 		let appComponent = <EgwFrameworkApp>document.createElement("egw-app");
-		appComponent.id = appname;
-		appComponent.name = appname;
+		appComponent.setAttribute("id", appname);
+		appComponent.setAttribute("name", appname);
 		appComponent.url = url ?? app?.url;
 
 		this.append(appComponent);
@@ -205,6 +211,11 @@ export class EgwFramework extends LitElement
 		return appComponent;
 	}
 
+	public get activeApp() : EgwFrameworkApp
+	{
+		return this.querySelector("egw-app[active]");
+	}
+
 	/**
 	 * Load a link into the framework
 	 *
@@ -261,6 +272,59 @@ export class EgwFramework extends LitElement
 		}
 	}
 
+	/**
+	 * Open a (centered) popup window with given size and url
+	 *
+	 * @param {string} _url
+	 * @param {number} _width
+	 * @param {number} _height
+	 * @param {string} _windowName or "_blank"
+	 * @param {string|boolean} _app app-name for framework to set correct opener or false for current app
+	 * @param {boolean} _returnID true: return window, false: return undefined
+	 * @param {type} _status "yes" or "no" to display status bar of popup
+	 * @param {DOMWindow} _parentWnd parent window
+	 * @returns {DOMWindow|undefined}
+	 */
+	public openPopup(_url, _width, _height, _windowName, _app, _returnID, _status, _parentWnd)
+	{
+		//Determine the window the popup should be opened in - normally this is the iframe of the currently active application
+		let parentWindow = _parentWnd || window;
+		let navigate = false;
+		let appEntry = null;
+		if(typeof _app != 'undefined' && _app !== false)
+		{
+			appEntry = this.getApplicationByName(_app);
+			if(appEntry && appEntry.browser == null)
+			{
+				navigate = true;
+				this.applicationTabNavigate(appEntry, appEntry.indexUrl);
+			}
+		}
+		else
+		{
+			appEntry = this.activeApp;
+		}
+
+		if(appEntry != null && appEntry.useIframe && (_app || !egw(parentWindow).is_popup()))
+		{
+			parentWindow = appEntry.iframe.contentWindow;
+		}
+
+		const windowID = egw(parentWindow).openPopup(_url, _width, _height, _windowName, _app, true, _status, true);
+
+		windowID.framework = this;
+
+		if(navigate)
+		{
+			window.setTimeout("framework.applicationTabNavigate(framework.activeApp, framework.activeApp.indexUrl);", 500);
+		}
+
+		if(_returnID !== false)
+		{
+			return windowID;
+		}
+	}
+
 	/**
 	 * Tries to obtain the application from a menuaction
 	 * @param {string} _url
@@ -287,7 +351,7 @@ export class EgwFramework extends LitElement
 	 */
 	public async print()
 	{
-		const appElement : EgwFrameworkApp = this.querySelector("egw-app[active]");
+		const appElement : EgwFrameworkApp = this.activeApp;
 		try
 		{
 			if(appElement)
@@ -356,7 +420,10 @@ export class EgwFramework extends LitElement
 
 		// Remove the tab + panel
 		tab.remove();
-		panel.remove();
+		if(panel)
+		{
+			panel.remove();
+		}
 	}
 
 	private updateTabs(activeTab)
diff --git a/kdots/js/EgwFrameworkApp.ts b/kdots/js/EgwFrameworkApp.ts
index 321419905c..a0326a2287 100644
--- a/kdots/js/EgwFrameworkApp.ts
+++ b/kdots/js/EgwFrameworkApp.ts
@@ -89,7 +89,7 @@ export class EgwFrameworkApp extends LitElement
 		];
 	}
 
-	@property()
+	@property({reflect: true})
 	name = "Application name";
 
 	@property()
@@ -240,9 +240,14 @@ export class EgwFrameworkApp extends LitElement
 		}
 	}
 
+	public getMenuaction(_fun, _ajax_exec_url, appName = "")
+	{
+		return this.framework.getMenuaction(_fun, _ajax_exec_url, appName || this.name);
+	}
+
 	public setSidebox(sideboxData, hash?)
 	{
-
+		console.log("Not implemented");
 	}
 
 	public showLeft()