extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-03 04:29:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Skip disabled widgets in iterateOver

Browse Source 
This fixes disabled widgets returning their value unexpectedly, and ID collisions when we have 2 widgets with the same ID, but disable one.
This commit is contained in:
nathan 2023-05-02 14:21:03 -06:00
parent ab195097f5
commit 46b7c5258b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/js/etemplate/Et2Widget/Et2Widget.ts
View File

@ -864,6 +864,11 @@ const Et2WidgetMixin = <T extends Constructor>(superClass : T) =>
iterateOver(_callback : Function, _context, _type) iterateOver(_callback : Function, _context, _type)
{ {
if(this.disabled)
{
// Don't if we're disabled
return;
}
if(typeof _type === "undefined" || _type === et2_widget || _type === Et2Widget || if(typeof _type === "undefined" || _type === et2_widget || _type === Et2Widget ||
typeof _type === 'function' && this instanceof _type || typeof _type === 'function' && this instanceof _type ||
et2_implements_registry[_type] && et2_implements_registry[_type](this)) et2_implements_registry[_type] && et2_implements_registry[_type](this))