extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-22 14:41:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Et2Select: Fix change event got fired too early

Browse Source 
Don't need to block the event if we didn't actually change the value.  This fixes changing to common preferences
This commit is contained in:
nathan 2022-11-09 15:34:28 -07:00
parent cbccbba108
commit 47a48b386f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/js/etemplate/Et2Select/Et2Select.ts
View File

@ -284,7 +284,7 @@ export class Et2Select extends Et2WithSearchMixin(Et2WidgetWithSelect)
{ {
let oldValue = this.value; let oldValue = this.value;
this.value = this.emptyLabel ? "" : "" + this.select_options[0]?.value; this.value = this.emptyLabel ? "" : "" + this.select_options[0]?.value;
this._block_change_event = true; this._block_change_event = (oldValue != this.value);
// ""+ to cast value of 0 to "0", to not replace with "" // ""+ to cast value of 0 to "0", to not replace with ""
this.requestUpdate("value", oldValue); this.requestUpdate("value", oldValue);
} }