From 4b8b454566eb1cb29e0bae4f4278ceb944557658 Mon Sep 17 00:00:00 2001 From: nathan Date: Wed, 25 Jan 2023 13:43:35 -0700 Subject: [PATCH] Make sure values are strings, otherwise they might not match comparison Should fix tracker list "Created by" filter losing display when you select a search result --- api/js/etemplate/Et2Select/FindSelectOptions.ts | 2 +- api/js/etemplate/Et2Select/SelectAccountMixin.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/js/etemplate/Et2Select/FindSelectOptions.ts b/api/js/etemplate/Et2Select/FindSelectOptions.ts index 977f8ddaf5..c4998ddcc3 100644 --- a/api/js/etemplate/Et2Select/FindSelectOptions.ts +++ b/api/js/etemplate/Et2Select/FindSelectOptions.ts @@ -241,7 +241,7 @@ export function cleanSelectOptions(options : SelectOption[] | string[] | object) { option = {label: key + ""}; } - option.value = option.value ?? key.trim(); // link_search prefixes keys with one space + option.value = "" + (option.value ?? key.trim()); // link_search prefixes keys with one space fixed_options.push(option); } } diff --git a/api/js/etemplate/Et2Select/SelectAccountMixin.ts b/api/js/etemplate/Et2Select/SelectAccountMixin.ts index 1952be19d7..7c390e0e29 100644 --- a/api/js/etemplate/Et2Select/SelectAccountMixin.ts +++ b/api/js/etemplate/Et2Select/SelectAccountMixin.ts @@ -85,7 +85,7 @@ export const SelectAccountMixin = >(superclass } let account_name = null; - let option = {value: id, label: id + " ..."}; + let option = {value: "" + id, label: id + " ..."}; this.account_options.push(option); if(this.value && (account_name = this.egw().link_title('api-accounts', id, false))) {