extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-22 14:41:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix for bug reported by Patrick Fraley: status changes of responsible user do not get save, if that user has no write grant

Browse Source
This commit is contained in:
Ralf Becker 2004-07-08 13:26:06 +00:00
parent b24f796eb2
commit 517865a274
1 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
infolog/inc/class.boinfolog.inc.php
View File

@ -281,7 +281,18 @@
function write($values,$check_defaults=True,$touch_modified=True) function write($values,$check_defaults=True,$touch_modified=True)
{ {
if ($values['info_id'] && !$this->check_access($values['info_id'],PHPGW_ACL_EDIT) || foreach($values as $key => $val)
{
if ($key[0] != '#' && substr($key,0,5) != 'info_')
{
$values['info_'.$key] = $val;
unset($values[$key]);
}
}
$status_only = $values['info_id'] && $values['info_responsible'] == $this->user &&
!$this->check_access($values['info_id'],PHPGW_ACL_EDIT); // responsible has implicit right to change status
if ($values['info_id'] && !$this->check_access($values['info_id'],PHPGW_ACL_EDIT) && !$status_only ||
!$values['info_id'] && $values['info_id_parent'] && !$this->check_access($values['info_id_parent'],PHPGW_ACL_ADD)) !$values['info_id'] && $values['info_id_parent'] && !$this->check_access($values['info_id_parent'],PHPGW_ACL_ADD))
{ {
if ($this->xmlrpc) if ($this->xmlrpc)
@ -294,13 +305,20 @@
{ {
$values = $this->xmlrpc2data($values); $values = $this->xmlrpc2data($values);
} }
foreach($values as $key => $val) if ($status_only) // make sure only status gets writen
{ {
if ($key[0] != '#' && substr($key,0,5) != 'info_') $set_enddate = !$values['info_enddate'] && // set enddate of finished job, only if its not already set
($values['info_status'] == 'done' || $values['info_status'] == 'billed');
$values = array(
'info_id' => $values['info_id'],
'info_status' => $values['info_status'],
);
if ($set_enddate)
{ {
$values['info_'.$key] = $val; $values['info_enddate'] = time();
unset($values[$key]);
} }
$check_defaults = False;
} }
if ($check_defaults) if ($check_defaults)
{ {