extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-24 06:48:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix Et2Description tries to open on click even if href or link are not set

Browse Source
This commit is contained in:
nathan 2022-02-03 13:52:14 -07:00
parent 026eaaaa71
commit 5b4c93b36a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
api/js/etemplate/Et2Description/Et2Description.ts
View File

@ -8,7 +8,7 @@
*/ */
import {Et2Widget} from "../Et2Widget/Et2Widget"; import {Et2Widget} from "../Et2Widget/Et2Widget";
import {html, css, LitElement} from "@lion/core"; import {css, html, LitElement} from "@lion/core";
import {et2_IDetachedDOM} from "../et2_core_interfaces"; import {et2_IDetachedDOM} from "../et2_core_interfaces";
import {activateLinks} from "../ActivateLinksDirective"; import {activateLinks} from "../ActivateLinksDirective";
@ -80,7 +80,8 @@ export class Et2Description extends Et2Widget(LitElement) implements et2_IDetach
this.activate_links = false; this.activate_links = false;
this.extra_link_popup = ""; this.extra_link_popup = "";
this.extra_link_target = "_browser"; this.extra_link_target = "_browser";
this.href = ""; // Don't initialize this to avoid href(unknown) when rendered
//this.href = "";
this.value = ""; this.value = "";
this._handleClick = this._handleClick.bind(this); this._handleClick = this._handleClick.bind(this);
@ -165,7 +166,7 @@ export class Et2Description extends Et2Widget(LitElement) implements et2_IDetach
{ {
this._init_blueimp_gallery(_ev, this.href); this._init_blueimp_gallery(_ev, this.href);
} }
else else if(this.mime_data || this.href)
{ {
egw(window).open_link(this.mime_data || this.href, this.extra_link_target, this.extra_link_popup, null, null, this.mime); egw(window).open_link(this.mime_data || this.href, this.extra_link_target, this.extra_link_popup, null, null, this.mime);
} }