extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-02-24 14:22:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

* API: no more session based cache for account list or searches for SQL backend (only for LDAP or AD)

Browse Source
This commit is contained in:
ralf 2024-01-29 17:00:06 +02:00
parent 582408257f
commit 5e671ea3f9
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
api/src/Accounts.php
View File

@ -22,14 +22,14 @@ use EGroupware\Api\Exception\AssertionFailed;
/** /**
* API - accounts * API - accounts
* *
* This class uses a backend class (at them moment SQL or LDAP) and implements some * This class uses a backend class and implements some caching on to top of the backend functions:
* caching on to top of the backend functions:
* *
* a) instance-wide account-data cache queried by account_id including also members(hips) * a) instance-wide account-data cache queried by account_id including also members(hips)
* implemented by self::cache_read($account_id) and self::cache_invalidate($account_ids) * implemented by self::cache_read($account_id) and self::cache_invalidate($account_ids)
* *
* b) session based cache for search, split_accounts and name2id * b) session based cache for search, split_accounts and name2id
* implemented by self::setup_cache() and self::cache_invalidate() * implemented by self::setup_cache() and self::cache_invalidate()
* SQL backend does NOT use the session, but just a static variable so caching on request base.
* *
* The backend only implements the read, save, delete, name2id and the {set_}members{hips} methods. * The backend only implements the read, save, delete, name2id and the {set_}members{hips} methods.
* The account class implements all other (eg. name2id, id2name) functions on top of these. * The account class implements all other (eg. name2id, id2name) functions on top of these.
@ -39,7 +39,7 @@ use EGroupware\Api\Exception\AssertionFailed;
class Accounts class Accounts
{ {
/** /**
* Enables the session-cache, currently switched on independent of the backend * Enables the session-cache, currently __construct switches it off for SQL backend
* *
* @var boolean * @var boolean
*/ */
@ -169,6 +169,9 @@ class Accounts
} }
$backend_class = 'EGroupware\\Api\\Accounts\\'.ucfirst($backend); $backend_class = 'EGroupware\\Api\\Accounts\\'.ucfirst($backend);
// switch session cache off for SQL
self::$use_session_cache = $backend !== 'sql';
if ($backend_object && !is_a($backend_object, $backend_class)) if ($backend_object && !is_a($backend_object, $backend_class))
{ {
throw new AssertionFailed("Invalid backend object, not a $backend_class object!"); throw new AssertionFailed("Invalid backend object, not a $backend_class object!");