Add a new function activateTab(widget) to activate a tab containing a given widget, move previous code inside tab widget to properly encapsulate it. Fixes broken tab selection with deferred tab loading, wrong tab shown if a widget has a validation error.

etemplate/js/et2_core_inputWidget.js

@@ -252,10 +252,7 @@ var et2_inputWidget = et2_valueWidget.extend([et2_IInput,et2_ISubmitListener],
 					tab = widget;
 					widget = widget._parent;
 				}
-				if(!widget || typeof widget.setActiveTab == 'undefined') return;
+				widget.activateTab(this);
-				var index = widget._children.indexOf(tab);
-				widget.setActiveTab(index);
-				console.log(widget);
 			}
 		}
 	},

etemplate/js/et2_widget_tabs.js

@@ -350,6 +350,31 @@ var et2_tabbox = et2_valueWidget.extend([et2_IInput],
 		this.tabContainer.children(":eq(" + _idx + ")").show();
 	},
 
+	/**
+	 * Activate the tab containing the given widget
+	 *
+	 * @param {et2_widget} widget
+	 * @return {bool} widget was found in a tab
+	 */
+	activateTab: function(widget) {
+		var tab = widget;
+		while(tab._parent && tab._parent._type !='tabbox')
+		{
+			tab = tab._parent;
+		}
+
+		var child_index = this._children.indexOf(tab);
+		for(var i = 0; i < this.tabData.length; i++)
+		{
+			if(this.tabData[i].widget == tab)
+			{
+				this.setActiveTab(i);
+				return true;
+			}
+		}
+		return false;
+	},
+
 	getDOMNode: function(_sender) {
 		if (_sender == this)
 		{