From 7f6088490a63f1d063a938e7f81f9aa114dcea60 Mon Sep 17 00:00:00 2001
From: nathangray <nathangray.bsc+github@gmail.com>
Date: Wed, 20 Mar 2019 14:37:39 -0600
Subject: [PATCH] Etemplate - Fix some Scrutinizer warnings

---
 api/src/Etemplate/Widget/Select.php | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/api/src/Etemplate/Widget/Select.php b/api/src/Etemplate/Widget/Select.php
index 5f8b7ecdd2..f16d7a0604 100644
--- a/api/src/Etemplate/Widget/Select.php
+++ b/api/src/Etemplate/Widget/Select.php
@@ -343,7 +343,7 @@ class Select extends Etemplate\Widget
 					self::$request->sel_options[$form_name] = array_merge(self::$request->sel_options[$form_name], $type_options);
 
 					// if no_lang was modified, forward modification to the client
-					if ($no_lang != $this->attr['no_lang'])
+					if ($no_lang != $this->attrs['no_lang'])
 					{
 						self::setElementAttribute($form_name, 'no_lang', $no_lang);
 					}
@@ -834,11 +834,9 @@ class Select extends Etemplate\Widget
 	{
 		$apps = array();
 		$parts = explode(":", $type2);
-		if (is_array($parts))
-		{
-			$exceptions = explode(";", $parts[1]);
-			$type2 = $parts[0];
-		}
+		$exceptions = explode(";", $parts[1]);
+		$type2 = $parts[0];
+
 		foreach ($GLOBALS['egw_info']['apps'] as $app => $data)
 		{
 			if ($type2 == 'enabled' && (!$data['enabled'] || !$data['status'] || $data['status'] == 3 || in_array($app, $exceptions)))
@@ -897,6 +895,7 @@ class Select extends Etemplate\Widget
 		{
 			$longnames = 1;
 		}
+		$info = '';
 		switch ($longnames)
 		{
 			case 2: