From 8f2420541a175b359735ad6261b25ef74978bbb5 Mon Sep 17 00:00:00 2001
From: Ralf Becker <ralfbecker@outdoor-training.de>
Date: Fri, 20 May 2005 17:00:12 +0000
Subject: [PATCH] fixed generation of options in select-boxes: now 0 == '0' !=
 '' when marking options as selected

---
 phpgwapi/inc/class.html.inc.php | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/phpgwapi/inc/class.html.inc.php b/phpgwapi/inc/class.html.inc.php
index 04d454b0ef..ab52668309 100644
--- a/phpgwapi/inc/class.html.inc.php
+++ b/phpgwapi/inc/class.html.inc.php
@@ -335,9 +335,20 @@ class html
 	 */
 	function select_option($value,$label,$selected,$no_lang=0,$title='')
 	{
-		//echo "select_option('$value','$label','".print_r($selected,true)."',".(int)$no_lang."</br>\n";
-		return '<option value="'.$this->htmlspecialchars($value).'"'.
-			(in_array($value,$selected,!$value) ? ' selected="1"' : '') .
+		// the following compares strict as strings, to archive: '0' == 0 != ''
+		// the first non-strict search via array_search, is for performance reasons, to not always search the whole array with php
+		if (($found = ($key = array_search($value,$selected)) !== false) && !$value)
+		{
+			if ((string) $value !== (string) $selected[$key])
+			{
+				$found = false;
+				foreach($selected as $sel)
+				{
+					if ($found = ((string) $value === (string) $selected[$key])) break;
+				}
+			}
+		}
+		return '<option value="'.$this->htmlspecialchars($value).'"'.($found  ? ' selected="1"' : '') .
 			($title ? ' title="'.$this->htmlspecialchars($no_lang ? $title : lang($title)).'"' : '') . '>'.
 			$this->htmlspecialchars($no_lang || $label == '' ? $label : lang($label)) . "</option>\n";
 	}