extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-26 09:53:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

* eTemplate/all apps: fixed not working display of floating point values in input fields for Chrome or Safarie (browsers supporting html5 input type="number")

Browse Source
This commit is contained in:
Ralf Becker 2012-10-31 09:20:24 +00:00
parent 14f690549c
commit 8fa3bdb88e
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
etemplate/inc/class.etemplate.inc.php
View File

@ -1879,6 +1879,11 @@ class etemplate extends boetemplate
/**
* Format a number according to user prefs with decimal and thousands separator (later only for readonly)
*
* HTML5 input type=number requires a float value with a dot, not comma!
* Chrome 22 and Safari 6 shows no value if a comma is used,
* while FF 16, IE 9 and 10 have no support for input type=number :-(
* --> use . as decimal separator for browser supporting html5 input type=number
*
* @param int|float|string $number
* @param int $num_decimal_places=2
* @param boolean $readonly=true
@ -1895,7 +1900,13 @@ class etemplate extends boetemplate
}
if ((string)$number === '') return '';
return number_format(str_replace(' ','',$number),$num_decimal_places,$dec_separator,$readonly ? $thousands_separator : '');
$ret = number_format(str_replace(' ','',$number), $num_decimal_places,
// need to use '.' as decimal separator for all browser supporting html5 input type=number
$dec_sep_used=$readonly || !in_array(html::$user_agent, array('chrome', 'safari', 'opera')) ?
$dec_separator : '.',
$readonly ? $thousands_separator : '');
//error_log(__METHOD__."($number, $num_decimal_places, $readonly) html::user_agent=".html::$user_agent.", dec_sep='$dec_separator' --> '$dec_sep_used', thousands_sep='$thousands_separator' returning '$ret'");
return $ret;
}
/**