extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-03 12:39:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixed creation of new contacts to use id=null (not longer -1)

Browse Source
This commit is contained in:
Ralf Becker 2006-07-09 23:35:16 +00:00
parent 2b549bcfe8
commit 95d6f36322
2 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
addressbook/inc/class.sifaddressbook.inc.php
View File

@ -191,9 +191,9 @@ class sifaddressbook extends bocontacts
* *
* @return int contact id * @return int contact id
* @param string $_vcard the vcard * @param string $_vcard the vcard
* @param int $_abID the internal addressbook id * @param int/string $_abID=null the internal addressbook id or !$_abID for a new enty
*/ */
function addSIF($_sifdata, $_abID) function addSIF($_sifdata, $_abID=null)
{ {
#error_log('ABID: '.$_abID); #error_log('ABID: '.$_abID);
#error_log(base64_decode($_sifdata)); #error_log(base64_decode($_sifdata));
@ -202,10 +202,7 @@ class sifaddressbook extends bocontacts
return false; return false;
} }
// ToDo Lars: This will not work on LDAP if($_abID) {
// either we use "if ($_abID)" and false, null, 0 as $_abID for new entries (prefered, as this works in all other apps)
// or we use something like "if ($_abID && $_abID != -1)" ...
if($_abID > 0) {
// update entry // update entry
$contact['id'] = $_abID; $contact['id'] = $_abID;
} }

8
addressbook/inc/class.vcaladdressbook.inc.php
View File

@ -19,8 +19,7 @@ class vcaladdressbook extends bocontacts
* import a vard into addressbook * import a vard into addressbook
* *
* @param string $_vcard the vcard * @param string $_vcard the vcard
* @param int $_abID the internal addressbook id * @param int/string $_abID=null the internal addressbook id or !$_abID for a new enty
* @param int $_vcardProfile profile id for mapping from vcard values to egw addressbook
* @return int contact id * @return int contact id
*/ */
function addVCard($_vcard, $_abID) function addVCard($_vcard, $_abID)
@ -29,10 +28,7 @@ class vcaladdressbook extends bocontacts
return false; return false;
} }
// ToDo Lars: This will not work on LDAP if($_abID) {
// either we use "if ($_abID)" and false, null, 0 as $_abID for new entries (prefered, as this works in all other apps)
// or we use something like "if ($_abID && $_abID != -1)" ...
if($_abID > 0) {
// update entry // update entry
$contact['id'] = $_abID; $contact['id'] = $_abID;
} }