diff --git a/api/js/egw_action/EgwAction.ts b/api/js/egw_action/EgwAction.ts index f7a173b99c..a516d79aff 100644 --- a/api/js/egw_action/EgwAction.ts +++ b/api/js/egw_action/EgwAction.ts @@ -236,7 +236,6 @@ export class EgwAction { public addAction(_type: string, _id: string, _caption: string = "", _iconUrl: string = "", _onExecute: string | Function = null, _allowOnMultiple: boolean = true): EgwAction { //Get the constructor for the given action type if (!(_type in window._egwActionClasses)) { - //TODO doesn't default instead of popup make more sense here?? _type = "popup" } @@ -403,7 +402,6 @@ export class EgwAction { * @param _target egwActionObject object, gets called for every object in _senders * @returns boolean true if none has disableClass, false otherwise */ - //TODO senders is never used in function body?? public enableClass(_action: EgwAction, _senders: any[], _target: any) { if (typeof _target == 'undefined') { return false; @@ -593,7 +591,7 @@ export class EgwAction { * The appendToGraph function generates an action tree which automatically contains * all parent elements. If the appendToGraph function is called for a * - * @param {not an array} _tree contains the tree structure - pass an object containing {root:Tree}??TODO + * @param {not an array} _tree contains the tree structure - pass an object containing {root:Tree} * the empty array "root" to this function {"root": []}. The result will be stored in * this array. * @param {boolean} _addChildren is used internally to prevent parent elements from diff --git a/api/js/egw_action/EgwActionObject.ts b/api/js/egw_action/EgwActionObject.ts index 61de2d4a8c..6a98652e3b 100644 --- a/api/js/egw_action/EgwActionObject.ts +++ b/api/js/egw_action/EgwActionObject.ts @@ -422,7 +422,7 @@ export class EgwActionObject { * @param {number} _changedBit * @param {number} _shiftState is the status of extra keys being pressed during the * selection process. - *///TODO check + */ _ifaceCallback(_newState: number, _changedBit: number, _shiftState?: number) { if (typeof _shiftState == "undefined") _shiftState = EGW_AO_SHIFT_STATE_NONE; diff --git a/api/js/egw_action/EgwActionObjectInterface.ts b/api/js/egw_action/EgwActionObjectInterface.ts index fe8447cde1..35b2a886c9 100644 --- a/api/js/egw_action/EgwActionObjectInterface.ts +++ b/api/js/egw_action/EgwActionObjectInterface.ts @@ -20,7 +20,6 @@ * @return {egwActionObjectInterface} */ export interface EgwActionObjectInterface { - //TODO abstract class might be better //properties _state: number; stateChangeCallback: Function; diff --git a/api/js/egw_action/EgwPopupActionImplementation.ts b/api/js/egw_action/EgwPopupActionImplementation.ts index d9f9672326..edb0d0904e 100644 --- a/api/js/egw_action/EgwPopupActionImplementation.ts +++ b/api/js/egw_action/EgwPopupActionImplementation.ts @@ -696,7 +696,6 @@ export class EgwPopupActionImplementation implements EgwActionImplementation { // the original //replace jQuery with spread operator // set the Prototype of the copy set_onExecute is not available otherwise - //TODO is this a valid/elegant way to do this??? give egwAction a methode clone -- make abstract parent class let drop_clone = drop[k].actionObj.clone()//Object.assign(Object.create(Object.getPrototypeOf(drop[k].actionObj)), drop[k].actionObj) //{...drop[k].actionObj}; //warning This method is really slow //Object.setPrototypeOf(drop_clone, EgwAction.prototype) diff --git a/api/js/egw_action/egwGlobal.ts b/api/js/egw_action/egwGlobal.ts index 72c13c221f..058f481f73 100644 --- a/api/js/egw_action/egwGlobal.ts +++ b/api/js/egw_action/egwGlobal.ts @@ -27,7 +27,6 @@ type EgwActionClasses = { default: EgwActionClassData,// actionManager: EgwActionClassData, drag: EgwActionClassData, drop: EgwActionClassData, popup: EgwActionClassData } -//TODO egw global.js declare global { interface Window { _egwActionClasses: EgwActionClasses; diff --git a/api/js/egw_action/egw_action.ts b/api/js/egw_action/egw_action.ts index 5354a75491..65b6fbb6a3 100755 --- a/api/js/egw_action/egw_action.ts +++ b/api/js/egw_action/egw_action.ts @@ -10,7 +10,6 @@ import {EGW_AO_STATE_NORMAL, EGW_AO_STATE_VISIBLE, EGW_AO_STATES} from './egw_action_constants'; import {egwSetBit} from './egw_action_common'; -import '././egw_action_popup'; import "./egw_menu_dhtmlx"; import {EgwAction} from "./EgwAction"; import {EgwActionManager} from "./EgwActionManager"; diff --git a/api/js/egw_action/egw_action_common.ts b/api/js/egw_action/egw_action_common.ts index fa8bfd7a2d..2dcdf7eb73 100755 --- a/api/js/egw_action/egw_action_common.ts +++ b/api/js/egw_action/egw_action_common.ts @@ -322,8 +322,6 @@ export class EgwFnct * 2. _value may be a boolean, which specifies whether the external onExecute handler * (passed as "_handler" in the constructor) will be used. * 3. _value may be a JS function which will then be called. - * - * TODO check if there should be other options */ public setValue(_value: any) { this.value = null; diff --git a/api/js/egw_action/egw_action_popup.ts b/api/js/egw_action/egw_action_popup.ts deleted file mode 100644 index 880a467b7f..0000000000 --- a/api/js/egw_action/egw_action_popup.ts +++ /dev/null @@ -1,12 +0,0 @@ -/** - * eGroupWare egw_action framework - egw action framework - * - * @link http://www.egroupware.org - * @author Andreas Stöckel - * @copyright 2011 by Andreas Stöckel - * @license http://opensource.org/licenses/gpl-license.php GPL - GNU General Public License - * @package egw_action - * @version $Id$ - */ - -//TODO this wants to be removed diff --git a/api/js/egw_action/egw_keymanager.ts b/api/js/egw_action/egw_keymanager.ts index 3eba2fc68d..4d6fe39966 100755 --- a/api/js/egw_action/egw_keymanager.ts +++ b/api/js/egw_action/egw_keymanager.ts @@ -111,7 +111,6 @@ ready(() => {//waits for DOM ready { // Check whether the event came from the sidebox - if yes, ignore //if(jQuery(keyboardEvent.target).parents("#egw_fw_sidemenu").length > 0) return; - //TODO check replacement with ralf or Nathan let target: any = keyboardEvent.target // this is some kind of element while ((target = target.parentNode) && target !== document) { diff --git a/api/js/egw_action/egw_menu.ts b/api/js/egw_action/egw_menu.ts index 686ce9405d..ebc6d00cf6 100755 --- a/api/js/egw_action/egw_menu.ts +++ b/api/js/egw_action/egw_menu.ts @@ -225,7 +225,7 @@ export class egwMenu /** * Key handler to allow keyboard navigation of menu - * TODO does this work? + * TODO does not work * * @return {boolean} true if we dealt with the keypress */