fix installation check to report and verify display_errors=0 as Off

was caused by comparison with "" and "" != "0", replaced with false now
This commit is contained in:
ralf 2022-08-12 08:48:28 +02:00
parent b5b3c873cf
commit 9e83b12413

View File

@ -55,7 +55,7 @@ $checks = array(
), ),
'safe_mode' => array( 'safe_mode' => array(
'func' => 'php_ini_check', 'func' => 'php_ini_check',
'value' => 0, 'value' => false,
'verbose_value' => 'Off', 'verbose_value' => 'Off',
'warning' => lang('safe_mode is turned on, which is generaly a good thing as it makes your install more secure.')."\n". 'warning' => lang('safe_mode is turned on, which is generaly a good thing as it makes your install more secure.')."\n".
lang('If safe_mode is turned on, EGw is not able to change certain settings on runtime, nor can we load any not yet loaded module.')."\n". lang('If safe_mode is turned on, EGw is not able to change certain settings on runtime, nor can we load any not yet loaded module.')."\n".
@ -64,19 +64,19 @@ $checks = array(
), ),
'magic_quotes_runtime' => array( 'magic_quotes_runtime' => array(
'func' => 'php_ini_check', 'func' => 'php_ini_check',
'value' => 0, 'value' => false,
'verbose_value' => 'Off', 'verbose_value' => 'Off',
'safe_mode' => 'magic_quotes_runtime = Off' 'safe_mode' => 'magic_quotes_runtime = Off'
), ),
'register_globals' => array( 'register_globals' => array(
'func' => 'php_ini_check', 'func' => 'php_ini_check',
'value' => 0, 'value' => false,
'verbose_value' => 'Off', 'verbose_value' => 'Off',
'warning' => lang("register_globals is turned On, EGroupware does NOT require it and it's generaly more secure to have it turned Off") 'warning' => lang("register_globals is turned On, EGroupware does NOT require it and it's generaly more secure to have it turned Off")
), ),
'display_errors' => array( 'display_errors' => array(
'func' => 'php_ini_check', 'func' => 'php_ini_check',
'value' => '', 'value' => false,
'verbose_value' => 'Off', 'verbose_value' => 'Off',
'warning' => lang('%1 is set to %2. This is NOT recommeded for a production system, as displayed error messages can contain passwords or other sensitive information!','display_errors',ini_get('display_errors')), 'warning' => lang('%1 is set to %2. This is NOT recommeded for a production system, as displayed error messages can contain passwords or other sensitive information!','display_errors',ini_get('display_errors')),
), ),
@ -96,7 +96,7 @@ $checks = array(
), ),
'file_uploads' => array( 'file_uploads' => array(
'func' => 'php_ini_check', 'func' => 'php_ini_check',
'value' => 1, 'value' => true,
'verbose_value' => 'On', 'verbose_value' => 'On',
'error' => lang('File uploads are switched off: You can NOT use any of the filemanagers, nor can you attach files in several applications!'), 'error' => lang('File uploads are switched off: You can NOT use any of the filemanagers, nor can you attach files in several applications!'),
), ),
@ -116,7 +116,7 @@ $checks = array(
), ),
'allow_url_fopen' => array( 'allow_url_fopen' => array(
'func' => 'php_ini_check', 'func' => 'php_ini_check',
'value' => 1, 'value' => true,
'verbose_value' => 'On', 'verbose_value' => 'On',
'error' => lang('%1 setting "%2" = %3 disallows access via http!', 'error' => lang('%1 setting "%2" = %3 disallows access via http!',
'php.ini', 'allow_url_fopen', array2string(ini_get('allow_url_fopen'))), 'php.ini', 'allow_url_fopen', array2string(ini_get('allow_url_fopen'))),