mirror of
https://github.com/EGroupware/egroupware.git
synced 2024-12-22 06:30:59 +01:00
Replace deprecated $response->script() call with $response->apply(), fixes file select window not closing in FF when opened through wiki
This commit is contained in:
parent
d6240a2410
commit
a10d4a2931
@ -194,12 +194,16 @@ class filemanager_select
|
||||
{
|
||||
$download_url = Vfs::download_url(Vfs::concat($content['path'],$content['name']));
|
||||
if ($download_url[0] == '/') $download_url = Egw::link($download_url);
|
||||
$js = "window.opener.CKEDITOR.tools.callFunction(".
|
||||
$content['ckeditorfuncnum'].",'".
|
||||
str_replace("'", "\\'", $download_url)."',".
|
||||
"'');\negw(window).close();";
|
||||
|
||||
$response = Api\Json\Response::get();
|
||||
$response->apply('window.opener.CKEDITOR.tools.callFunction', array(
|
||||
$content['ckeditorfuncnum'],
|
||||
str_replace("'", "\\'", $download_url)
|
||||
));
|
||||
Framework::window_close();
|
||||
exit();
|
||||
}
|
||||
if(Api\Json\Response::isJSONResponse() && !($content['method'] == 'ckeditor_return'))
|
||||
if(Api\Json\Response::isJSONResponse())
|
||||
{
|
||||
$response = Api\Json\Response::get();
|
||||
if($js)
|
||||
@ -208,7 +212,8 @@ class filemanager_select
|
||||
}
|
||||
// Ahh!
|
||||
// The vfs-select widget looks for this
|
||||
$response->script('this.selected_files = '.json_encode($files) . '; egw(this).close();');
|
||||
$response->script('this.selected_files = '.json_encode($files) . ';');
|
||||
Framework::window_close();
|
||||
}
|
||||
else
|
||||
{
|
||||
|
Loading…
Reference in New Issue
Block a user