extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-03 04:29:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

improve performance by calling _link_actions way less often

Browse Source
This commit is contained in:
milan 2024-03-14 18:24:01 +01:00
parent 8bef376c5c
commit a61dfb8d0c
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
api/js/etemplate/Et2Tree/Et2Tree.ts
View File

@ -143,12 +143,26 @@ export class Et2Tree extends Et2WidgetWithSelectMixin(LitElement)
this._selectOptions = results?.item ?? []; this._selectOptions = results?.item ?? [];
this._initCurrent() this._initCurrent()
this.requestUpdate("_selectOptions"); this.requestUpdate("_selectOptions");
this.updateComplete.then((value) => {
if (value)
{
this._link_actions(this.actions)
}
})
}) })
} }
if (this._selectOptions?.length) this._initCurrent() if (this._selectOptions?.length) this._initCurrent()
// Actions can't be initialized without being connected to InstanceManager // Actions can't be initialized without being connected to InstanceManager
this._initActions(); this._initActions();
//TODO do it on first updated
this._link_actions(this.actions)
}
protected updated(_changedProperties: PropertyValues)
{
super.updated(_changedProperties);
} }
//Sl-Trees handle their own onClick events //Sl-Trees handle their own onClick events
@ -211,7 +225,7 @@ export class Et2Tree extends Et2WidgetWithSelectMixin(LitElement)
right: 0.5em; right: 0.5em;
} }
` `
//todo bg color on drop-hover should take precedence over selected color change
] ]
} }
@ -280,6 +294,7 @@ export class Et2Tree extends Et2WidgetWithSelectMixin(LitElement)
if(new_options?.length) if(new_options?.length)
{ {
this._selectOptions = new_options; this._selectOptions = new_options;
this.updateComplete.then(()=>this._link_actions(this.actions))
} }
} }
@ -886,11 +901,6 @@ export class Et2Tree extends Et2WidgetWithSelectMixin(LitElement)
return action_links; return action_links;
} }
protected updated(_changedProperties: PropertyValues)
{
this._link_actions(this.actions)
super.updated(_changedProperties);
}
/** /**
* *