extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-24 00:43:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

- Apply 'none' user selection preference (with admin consideration)

Browse Source 
- Avoid potential infinite loop with no select options
This commit is contained in:
Nathan Gray 2014-10-06 22:11:27 +00:00
parent 0db144feb9
commit a6ac5155ac
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
etemplate/js/et2_widget_selectAccount.js
View File

@ -111,6 +111,11 @@ var et2_selectAccount = et2_selectbox.extend(
switch(type)
{
case 'none':
if(typeof egw.user('apps').admin == 'undefined')
{
this.options.select_options = {};
break;
}
case 'selectbox':
case 'groupmembers':
default:
@ -164,9 +169,10 @@ var et2_selectAccount = et2_selectbox.extend(
*/
createMultiSelect: function() {
this._super.apply(this, arguments);
var type = this.egw().preference('account_selection', 'common');
if(type == 'none' && typeof egw.user('apps').admin == 'undefined') return;
this._super.apply(this, arguments);
this.options.select_options = this._get_accounts();

4
etemplate/js/et2_widget_selectbox.js
View File

@ -440,7 +440,9 @@ var et2_selectbox = et2_inputWidget.extend(
{
_value = _value.split(',');
}
if(this.input !== null && this.options.select_options && this.input.children().length == 0)
if(this.input !== null && this.options.select_options && (
!jQuery.isEmptyObject(this.options.select_options) || this.options.select_options.length > 0
) && this.input.children().length == 0)
{
// No options set yet
this.set_select_options(this.options.select_options);