From abb5ffd508d7e9dff0b3c51b30ae309498654871 Mon Sep 17 00:00:00 2001 From: nathangray Date: Wed, 19 Apr 2017 12:51:58 -0600 Subject: [PATCH] Do not change XMLNode, that changes the cached template. Clone it, then change it to avoid weird side effects. --- api/js/etemplate/et2_widget_tabs.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/api/js/etemplate/et2_widget_tabs.js b/api/js/etemplate/et2_widget_tabs.js index f7bb2e08d9..3d021a2b8b 100644 --- a/api/js/etemplate/et2_widget_tabs.js +++ b/api/js/etemplate/et2_widget_tabs.js @@ -283,6 +283,8 @@ var et2_tabbox = (function(){ "use strict"; return et2_valueWidget.extend([et2_I if(tabData.hidden) { // Set hidden tab to readonly, so widgets aren't active + // Do not modify the XMLNode, or the change will be cached for all + tabData.XMLNode = tabData.XMLNode.cloneNode(); tabData.XMLNode.setAttribute('readonly', true); } tabData.widget = this.createElementFromNode(tabData.XMLNode,tabData.XMLNode.nodeName.toLowerCase());