extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-23 08:23:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

"we explicitly need to delete custom fields, if value is empty or field allows multiple values or we have no unique index"

Browse Source
This commit is contained in:
Ralf Becker 2009-08-10 09:12:35 +00:00
parent 1e90070d36
commit ae855c4979
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
etemplate/inc/class.so_sql_cf.inc.php
View File

@ -76,6 +76,13 @@ class so_sql_cf extends so_sql
var $extra_join_order;
var $extra_join_filter;
/**
* Does extra table has a unique index (over id and name)
*
* @var boolean
*/
var $extra_has_unique_index;
/**
* Custom fields of $app, read by the constructor
*
@ -144,6 +151,9 @@ class so_sql_cf extends so_sql
throw new egw_exception_wrong_parameter("$col column $extra_table.{$this->$col} is NOT defined!");
}
}
// check if our extra table has a unique index (if not we have to delete the old values, as replacing does not work!)
$this->extra_has_unique_index = $extra_defs['pk'] || $extra_defs['uc'];
// setting up our extra joins, now we know table and column names
$this->extra_join = " LEFT JOIN $extra_table ON $table.$this->autoinc_id=$extra_table.$this->extra_id";
$this->extra_join_order = " LEFT JOIN $extra_table extra_order ON $table.$this->autoinc_id=extra_order.$this->extra_id";
@ -208,10 +218,11 @@ class so_sql_cf extends so_sql
);
$is_multiple = $this->is_multiple($name);
if(empty($data[$field]) || $is_multiple) // dont write empty values
// we explicitly need to delete fields, if value is empty or field allows multiple values or we have no unique index
if(empty($data[$field]) || $is_multiple || !$this->extra_has_unique_index)
{
$this->db->delete($this->extra_table,$where,__LINE__,__FILE__,$this->app); // just delete them, in case they were previously set
if (!$is_multiple) continue;
$this->db->delete($this->extra_table,$where,__LINE__,__FILE__,$this->app);
if (empty($data[$field])) continue; // nothing else to do for empty values
}
foreach($is_multiple && !is_array($data[$field]) ? explode(',',$data[$field]) : (array)$data[$field] as $value)
{