From b43dd8f2c3959d75fdf5f37ce994459c4d6b4a67 Mon Sep 17 00:00:00 2001 From: nathan Date: Tue, 11 Oct 2022 13:14:55 -0600 Subject: [PATCH] Fix infinite reload in preference dialog when switching to common preferences --- preferences/inc/class.preferences_settings.inc.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/preferences/inc/class.preferences_settings.inc.php b/preferences/inc/class.preferences_settings.inc.php index ea18fbfea5..1e5dba82a3 100644 --- a/preferences/inc/class.preferences_settings.inc.php +++ b/preferences/inc/class.preferences_settings.inc.php @@ -169,6 +169,11 @@ class preferences_settings $sel_options = $readonlys = null; $data = $this->get_content($appname, $type, $sel_options, $readonlys, $preserve['types'], $tpl); + if($data['appname'] == 'common') + { + // 'common' is not in the options list, we use the empty label for common + $data['appname'] = ''; + } $preserve['appname'] = $preserve['old_appname'] = $data['appname']; $preserve['type'] = $preserve['old_type'] = $data['type']; $preserve['is_admin'] = $is_admin;