extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-22 14:41:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix needing to save twice to clear a multi-select custom field.

Browse Source
This commit is contained in:
Nathan Gray 2013-10-01 11:24:18 +00:00
parent 53880e2063
commit b6a701ea34
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
infolog/inc/class.infolog_bo.inc.php
View File

@ -932,6 +932,9 @@ class infolog_bo
} }
$values['info_id'] = $info_id; $values['info_id'] = $info_id;
$to_write['info_id'] = $info_id; $to_write['info_id'] = $info_id;
error_log(__LINE__);
error_log(array2string($values));
// if the info responbsible array is not passed, fetch it from old. // if the info responbsible array is not passed, fetch it from old.
if (!array_key_exists('info_responsible',$values)) $values['info_responsible'] = $old['info_responsible']; if (!array_key_exists('info_responsible',$values)) $values['info_responsible'] = $old['info_responsible'];
if (!is_array($values['info_responsible'])) // this should not happen, bug it does ;-) if (!is_array($values['info_responsible'])) // this should not happen, bug it does ;-)
@ -962,6 +965,15 @@ class infolog_bo
if ($old && ($missing_fields = array_diff_key($old,$values))) if ($old && ($missing_fields = array_diff_key($old,$values)))
{ {
// Some custom fields (multiselect with nothing selected) will be missing,
// and that's OK. Don't put them back.
foreach($missing_fields as $field => $m_value)
{
if(array_key_exists($field, $values_in))
{
unset($missing_fields[$field]);
}
}
$values = array_merge($values,$missing_fields); $values = array_merge($values,$missing_fields);
} }
// Add keys missing in the $to_write array // Add keys missing in the $to_write array