From ba3aa1c4b5d831a287c6b7630e9a950a5e98076e Mon Sep 17 00:00:00 2001
From: nathan <nathangray.bsc+github@gmail.com>
Date: Mon, 17 Jun 2024 09:26:10 -0600
Subject: [PATCH] EgwMenuShoelace bugfixes - Fix menu does not do action - Fix
 menus accumulate in DOM

---
 api/js/egw_action/EgwMenuShoelace.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/api/js/egw_action/EgwMenuShoelace.ts b/api/js/egw_action/EgwMenuShoelace.ts
index 5cd72ed2e9..4e8f7ed6a0 100644
--- a/api/js/egw_action/EgwMenuShoelace.ts
+++ b/api/js/egw_action/EgwMenuShoelace.ts
@@ -103,6 +103,9 @@ export class EgwMenuShoelace extends LitElement
 	public hide()
 	{
 		this.popup.active = false;
+
+		// egw_menu always creates a new menu
+		this.remove();
 	}
 
 	handleSelect(event)
@@ -115,7 +118,7 @@ export class EgwMenuShoelace extends LitElement
 		if(event.detail.item.value)
 		{
 			const item = <egwMenuItem>event.detail.item.value;
-			if(item.checkbox || typeof item.checked !== "undefined")
+			if(item.checkbox)
 			{
 				item.checked = event.detail.item.checked;
 				return;