From be85db6c5369e2b9bee19cc49121a926c181baac Mon Sep 17 00:00:00 2001 From: nathangray Date: Mon, 27 Feb 2017 08:52:20 -0700 Subject: [PATCH] Fix infolog details / no details filter reloads list instead of changing details --- infolog/js/app.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/infolog/js/app.js b/infolog/js/app.js index 7efae9eef0..084f772877 100644 --- a/infolog/js/app.js +++ b/infolog/js/app.js @@ -243,7 +243,7 @@ app.classes.infolog = AppJS.extend( if (nm && filter2) { // Show / hide descriptions - this.show_details(filter2.value == 'all', nm.getDOMNode(nm)); + this.show_details(filter2.get_value() === 'all', nm.getDOMNode(nm)); } // Only change columns for a real user event, to avoid interfering with @@ -273,9 +273,16 @@ app.classes.infolog = AppJS.extend( nm.dataview.getColumnMgr().columns[i].set_visibility(colData[i].visible); } nm.dataview.getColumnMgr().updated = true; - // Update page + + // Update page - set update_in_progress to true to avoid triggering + // the change handler and looping if the user has a custom field + // column change + var in_progress = nm.update_in_progress; + nm.update_in_progress = true; nm.dataview.updateColumns(); + nm.update_in_progress = in_progress; } + return false; }, /**