extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-01-08 06:59:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix unhandled exception stalling LDAP/AD account sync

Browse Source 
not (yet) fixing the cause, but logging it as error and continuing
This commit is contained in:
ralf 2023-02-21 11:17:11 +01:00
parent 0abb6aa23a
commit dd48bd3c04
1 changed files with 26 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
api/src/Accounts/Import.php
View File

@ -251,7 +251,7 @@ class Import
} }
else else
{ {
$this->logger("Error creaing user '$account[account_lid]' (#$account[account_id])", 'error'); $this->logger("Error creating user '$account[account_lid]' (#$account[account_id])", 'error');
$errors++; $errors++;
continue; continue;
} }
@ -284,22 +284,33 @@ class Import
$this->logger("Dry-run: would updated user '$account[account_lid]' (#$account_id): " . $this->logger("Dry-run: would updated user '$account[account_lid]' (#$account_id): " .
json_encode($diff, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES), 'detail'); json_encode($diff, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES), 'detail');
} }
elseif ($this->accounts_sql->save($to_update) > 0)
{
// run editaccount hook to create eg. home-directory or mail account
Api\Hooks::process($to_update+array(
'location' => 'editaccount'
),False,True); // called for every app now, not only enabled ones)
$this->logger("Successful updated user '$account[account_lid]' (#$account_id): " .
json_encode($diff, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES), 'detail');
if (!$new) $new = false;
}
else else
{ {
$this->logger("Error updating user '$account[account_lid]' (#$account_id)", 'error'); try {
$errors++; if ($this->accounts_sql->save($to_update) > 0)
continue; {
// run editaccount hook to create eg. home-directory or mail account
Api\Hooks::process($to_update+array(
'location' => 'editaccount'
),False,True); // called for every app now, not only enabled ones)
$this->logger("Successful updated user '$account[account_lid]' (#$account_id): " .
json_encode($diff, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES), 'detail');
if (!$new) $new = false;
}
else
{
$this->logger("Error updating user '$account[account_lid]' (#$account_id)", 'error');
$errors++;
continue;
}
}
catch (\Exception $e) {
$this->logger("Error updating user '$account[account_lid]' (#$account_id): ".$e->getMessage().' ('.$e->getCode().')', 'error');
$this->logger('$to_update='.json_encode($to_update, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES), 'error');
$errors++;
continue;
}
} }
} }
else else